Skip to content

Commit

Permalink
[8948] Not check victim at apply SPELL_AURA_MOD_SPELL_CRIT_CHANCE_SCH…
Browse files Browse the repository at this point in the history
…OOL for ranged spells

In same way as for other cases. For consistance.
  • Loading branch information
VladimirMangos committed Dec 8, 2009
1 parent 1b4c5d0 commit 4a6ab54
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 2 additions & 3 deletions src/game/Unit.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9046,10 +9046,9 @@ bool Unit::isSpellCrit(Unit *pVictim, SpellEntry const *spellProto, SpellSchoolM
case SPELL_DAMAGE_CLASS_RANGED:
{
if (pVictim)
{
crit_chance = GetUnitCriticalChance(attackType, pVictim);
crit_chance+= GetTotalAuraModifierByMiscMask(SPELL_AURA_MOD_SPELL_CRIT_CHANCE_SCHOOL, schoolMask);
}

crit_chance+= GetTotalAuraModifierByMiscMask(SPELL_AURA_MOD_SPELL_CRIT_CHANCE_SCHOOL, schoolMask);
break;
}
default:
Expand Down
2 changes: 1 addition & 1 deletion src/shared/revision_nr.h
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#ifndef __REVISION_NR_H__
#define __REVISION_NR_H__
#define REVISION_NR "8947"
#define REVISION_NR "8948"
#endif // __REVISION_NR_H__

1 comment on commit 4a6ab54

@tst12
Copy link

@tst12 tst12 commented on 4a6ab54 Dec 9, 2009

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its really need empty line after if()?
(same case for backport http://github.com/mangos/mangos/commit/c5fceed9bf1a8151f638eb87dc7aaa6dca1ee7dc)

Please sign in to comment.