Skip to content

Commit

Permalink
[10437] Fix engineering bonus for injectors
Browse files Browse the repository at this point in the history
Signed-off-by: Laise <fenrisse@gmail.com>
  • Loading branch information
lavinelu authored and Laise committed Sep 3, 2010
1 parent df3a175 commit 928f361
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 1 deletion.
4 changes: 4 additions & 0 deletions sql/mangos_spell_check.sql
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,10 @@ INSERT INTO spell_check (spellid,SpellFamilyName,SpellFamilyMaskA,SpellFamilyMas
(67333,-1, -1, -1, -1, -1, -1, 31, -1,-1,'Meteor Fists', 'Spell::EffectWeaponDmg'),
(67485, 0, -1, -1, -1, -1, -1, 2, -1,-1,'Hand of Rekoning', 'Spell::EffectSchoolDMG'),
(67485,-1, -1, -1, -1, -1, -1, -1, -1,-1,'Hand of Rekoning', 'Spell::cast'),
(67486,-1, -1, -1, -1, -1, -1, -1, -1,-1,'Healing Potion Injector', 'Spell::EffectHeal'),
(67487,-1, -1, -1, -1, -1, -1, -1, -1,-1,'Mana Potion Injector', 'Spell::EffectEnergize'),
(67489,-1, -1, -1, -1, -1, -1, -1, -1,-1,'Runic Healing Injector', 'Spell::EffectHeal'),
(67490,-1, -1, -1, -1, -1, -1, -1, -1,-1,'Runic Mana Injector', 'Spell::EffectEnergize'),
(67700, 0, -1, -1, -1, -1, -1, -1, -1,-1,'Penetrating Cold', 'Spell::SetTargetMap'),

This comment has been minimized.

Copy link
@Singlem

Singlem Sep 3, 2010

Why was these not added to a Update SQL?

This comment has been minimized.

Copy link
@Laise

Laise Sep 3, 2010

Contributor

Why it should sql update?

This comment has been minimized.

Copy link
@kamikazetg

kamikazetg Sep 4, 2010

I believe he means for the people that update in sql\updates. Though, I don't particularly see it as necessary for this table.

(68082,-1, -1, -1, -1, -1, -1, 30, -1,-1,'Glyph of Seal of Command', 'Spell::EffectEnergize'),
(68509, 0, -1, -1, -1, -1, -1, -1, -1,-1,'Penetrating Cold', 'Spell::SetTargetMap'),
Expand Down
18 changes: 18 additions & 0 deletions src/game/SpellEffects.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3246,6 +3246,13 @@ void Spell::EffectHeal(SpellEffectIndex /*eff_idx*/)

addhealth += tickheal * tickcount;
}
// Runic Healing Injector & Healing Potion Injector effect increase for engineers
else if ((m_spellInfo->Id == 67486 || m_spellInfo->Id == 67489) && unitTarget->GetTypeId() == TYPEID_PLAYER)
{
Player* player = (Player*)unitTarget;
if (player->HasSkill(SKILL_ENGINERING))
addhealth += int32(addhealth * 0.25);
}

// Chain Healing
if (m_spellInfo->SpellFamilyName == SPELLFAMILY_SHAMAN && m_spellInfo->SpellFamilyFlags & UI64LIT(0x0000000000000100))
Expand Down Expand Up @@ -3543,6 +3550,17 @@ void Spell::EffectEnergize(SpellEffectIndex eff_idx)
case 68082: // Glyph of Seal of Command
damage = damage * unitTarget->GetCreateMana() / 100;
break;
case 67487: // Mana Potion Injector
case 67490: // Runic Mana Injector
{
if (unitTarget->GetTypeId() == TYPEID_PLAYER)
{
Player* player = (Player*)unitTarget;
if (player->HasSkill(SKILL_ENGINERING))

This comment has been minimized.

Copy link
@DarkYodah

DarkYodah Sep 3, 2010

Contributor

shouldn't it be
SKILL_ENGINEERING
instead of
SKILL_ENGINERING (everywhere...)

This comment has been minimized.

Copy link
@Olynn

Olynn Sep 5, 2010

Indeed. looks like a typo.

This comment has been minimized.

Copy link
@DarkYodah

DarkYodah Sep 5, 2010

Contributor

Will post a patch file on the MaNGOS forums...

damage += int32(damage * 0.25);
}
break;
}
default:
break;
}
Expand Down
2 changes: 1 addition & 1 deletion src/shared/revision_nr.h
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#ifndef __REVISION_NR_H__
#define __REVISION_NR_H__
#define REVISION_NR "10436"
#define REVISION_NR "10437"
#endif // __REVISION_NR_H__

1 comment on commit 928f361

@technoir42
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonus works even with 1 skill point?

Please sign in to comment.