Skip to content

Commit

Permalink
[9118] Fixed problem with not set AchievementCriteriaRequirementSet::…
Browse files Browse the repository at this point in the history
…criteria_id

This important for support ACHIEVEMENT_CRITERIA_REQUIRE_INSTANCE_SCRIPT

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
  • Loading branch information
GriffonHeart authored and VladimirMangos committed Jan 7, 2010
1 parent c0c9919 commit beed0d4
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions src/game/AchievementMgr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1912,6 +1912,7 @@ void AchievementGlobalMgr::LoadAchievementCriteriaRequirements()

// this will allocate empty data set storage
AchievementCriteriaRequirementSet& dataSet = m_criteriaRequirementMap[criteria_id];
dataSet.SetCriteriaId(criteria_id);

// counting disable criteria requirements
if (data.requirementType == ACHIEVEMENT_CRITERIA_REQUIRE_DISABLED)
Expand Down
2 changes: 1 addition & 1 deletion src/game/AchievementMgr.h
Original file line number Diff line number Diff line change
Expand Up @@ -182,10 +182,10 @@ struct AchievementCriteriaRequirement
struct AchievementCriteriaRequirementSet
{
AchievementCriteriaRequirementSet() : criteria_id(0) {}
explicit AchievementCriteriaRequirementSet(uint32 id) : criteria_id(id) {}
typedef std::vector<AchievementCriteriaRequirement> Storage;
void Add(AchievementCriteriaRequirement const& data) { storage.push_back(data); }
bool Meets(Player const* source, Unit const* target, uint32 miscvalue = 0) const;
void SetCriteriaId(uint32 id) {criteria_id = id;}
private:
uint32 criteria_id;
Storage storage;
Expand Down
2 changes: 1 addition & 1 deletion src/shared/revision_nr.h
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#ifndef __REVISION_NR_H__
#define __REVISION_NR_H__
#define REVISION_NR "9117"
#define REVISION_NR "9118"
#endif // __REVISION_NR_H__

0 comments on commit beed0d4

Please sign in to comment.