Skip to content

Commit

Permalink
[10116] Remove some wrongly initialized fields for dynamic object.
Browse files Browse the repository at this point in the history
This will correct visual appearance of spells like for example id 26573.

Signed-off-by: NoFantasy <nofantasy@nf.no>
  • Loading branch information
NoFantasy committed Jun 28, 2010
1 parent 3a9ce83 commit 775063d
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
10 changes: 5 additions & 5 deletions src/game/DynamicObject.cpp
Expand Up @@ -73,11 +73,11 @@ bool DynamicObject::Create( uint32 guidlow, Unit *caster, uint32 spellId, SpellE
SetEntry(spellId);
SetObjectScale(DEFAULT_OBJECT_SCALE);

SetUInt64Value( DYNAMICOBJECT_CASTER, caster->GetGUID() );
SetUInt32Value( DYNAMICOBJECT_BYTES, 0x00000001 );
SetUInt32Value( DYNAMICOBJECT_SPELLID, spellId );
SetFloatValue( DYNAMICOBJECT_RADIUS, radius);
SetUInt32Value( DYNAMICOBJECT_CASTTIME, getMSTime() ); // new 2.4.0
SetUInt64Value(DYNAMICOBJECT_CASTER, caster->GetGUID());
SetUInt32Value(DYNAMICOBJECT_BYTES, 0x00000001);
SetUInt32Value(DYNAMICOBJECT_SPELLID, spellId);
SetFloatValue(DYNAMICOBJECT_RADIUS, radius);
SetUInt32Value(DYNAMICOBJECT_CASTTIME, getMSTime()); // new 2.4.0

m_aliveDuration = duration;
m_radius = radius;
Expand Down
8 changes: 4 additions & 4 deletions src/game/SpellEffects.cpp
Expand Up @@ -3446,9 +3446,7 @@ void Spell::EffectPersistentAA(SpellEffectIndex eff_idx)
delete dynObj;
return;
}
dynObj->SetUInt32Value(OBJECT_FIELD_TYPE, 65);
dynObj->SetUInt32Value(GAMEOBJECT_DISPLAYID, 368003);
dynObj->SetUInt32Value(DYNAMICOBJECT_BYTES, 0x01eeeeee);

m_caster->AddDynObject(dynObj);
m_caster->GetMap()->Add(dynObj);
}
Expand Down Expand Up @@ -4240,8 +4238,10 @@ void Spell::EffectAddFarsight(SpellEffectIndex eff_idx)
delete dynObj;
return;
}
dynObj->SetUInt32Value(OBJECT_FIELD_TYPE, 65);

// DYNAMICOBJECT_BYTES is appareltly different from the default bytes set in ::Create
dynObj->SetUInt32Value(DYNAMICOBJECT_BYTES, 0x80000002);

m_caster->AddDynObject(dynObj);
m_caster->GetMap()->Add(dynObj);

Expand Down
2 changes: 1 addition & 1 deletion src/shared/revision_nr.h
@@ -1,4 +1,4 @@
#ifndef __REVISION_NR_H__
#define __REVISION_NR_H__
#define REVISION_NR "10115"
#define REVISION_NR "10116"
#endif // __REVISION_NR_H__

0 comments on commit 775063d

Please sign in to comment.