Skip to content

Commit

Permalink
more test checks and comments, re #12610
Browse files Browse the repository at this point in the history
  • Loading branch information
FedeMPouzols committed Aug 12, 2015
1 parent 639f604 commit c667bc9
Showing 1 changed file with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@ class EnggDiffractionPresenterTest : public CxxTest::TestSuite {
TS_ASSERT(testing::Mock::VerifyAndClearExpectations(m_view.get()));
}

// TODO: There should be a few basic tests on the presenter here, including
// methods like: parseCalibrateFilename, buildCalibrateSuggestedFilename, etc.
// Several of these are indirectly tested through some of the GUI-mock-based
// tests below but should be tested as isolated methods here at the beginning.

void test_start() {
testing::NiceMock<MockEnggDiffractionView> mockView;
MantidQt::CustomInterfaces::EnggDiffractionPresenter pres(&mockView);
Expand All @@ -64,7 +69,8 @@ class EnggDiffractionPresenterTest : public CxxTest::TestSuite {
Return(calibSettings));

const std::string mockFname = "foo.par";
EXPECT_CALL(mockView, askExistingCalibFilename()).Times(1).WillOnce(Return(mockFname));
EXPECT_CALL(mockView, askExistingCalibFilename()).Times(1).WillOnce(
Return(mockFname));
EXPECT_CALL(mockView, newCalibLoaded(testing::_, testing::_, mockFname))
.Times(1);

Expand Down

0 comments on commit c667bc9

Please sign in to comment.