Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract ROI into a new workspace #11824

Closed
peterfpeterson opened this issue Jan 28, 2015 · 3 comments · Fixed by #13374
Closed

Extract ROI into a new workspace #11824

peterfpeterson opened this issue Jan 28, 2015 · 3 comments · Fixed by #13374
Assignees
@NickDraper
Labels
Framework Issues and pull requests related to components in the Framework

Comments

@peterfpeterson
Copy link
Member

This issue was originally TRAC 10985

SANS would like to define an ROI, or a set of ROI, then extract those selected pixels into a new workspace.
@peterfpeterson peterfpeterson added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
AndreiSavici added a commit that referenced this issue Jun 5, 2015
@AndreiSavici
Pylint for fit functions. refs #11824
ae2f061
AndreiSavici added a commit that referenced this issue Jun 5, 2015
@AndreiSavici
Some algorithms. Refs #11824
f1aca34
AndreiSavici added a commit that referenced this issue Jun 5, 2015
@AndreiSavici
MaskBTP. Refs #11824
50070ab
AndreiSavici added a commit that referenced this issue Jun 5, 2015
@AndreiSavici
A few more algorithms. refs #11824
fe8d63a
AndreiSavici added a commit that referenced this issue Jun 5, 2015
@AndreiSavici
More algs. Refs #11824
b420ad5
AndreiSavici added a commit that referenced this issue Jun 5, 2015
@AndreiSavici
One more try. Refs #11824
4d60207
AndreiSavici added a commit that referenced this issue Jun 5, 2015
@AndreiSavici
Fix unit tests. Refs #11824
06eaa4f
AndreiSavici added a commit that referenced this issue Jun 5, 2015
@AndreiSavici
A few more warnings. Refs #11824
c50f149
AndreiSavici added a commit that referenced this issue Jun 5, 2015
@AndreiSavici
Refs #11824. Merge branch 'master' into 11824_pylint_in_algs_and_funcs
ec63365 
Conflicts:
	Code/Mantid/Framework/PythonInterface/plugins/algorithms/WorkflowAlgorithms/IndirectCalibration.py
	Code/Mantid/Framework/PythonInterface/plugins/algorithms/WorkflowAlgorithms/IndirectResolution.py
AndreiSavici added a commit that referenced this issue Jun 5, 2015
@AndreiSavici
Refs #11824. More fixes
6904325
@NickDraper
Copy link
Contributor

This is possible, but some of the labels are unclear so it is not so easy to spot

image
Under the Save button in Group mode is "Extract Detectors to workspace"

Which produces this
image

@NickDraper
Copy link
Contributor

I propose to change the Mask/Group option list to Mask/ROI/Group and update the operations underneath accordingly.

@NickDraper
Copy link
Contributor

something a bit like this

image

NickDraper added a commit that referenced this issue Aug 13, 2015
@NickDraper
Add a region of Interest more to the instrument view
874a9b4 
re #11824
@NickDraper NickDraper mentioned this issue Aug 13, 2015
Merged
NickDraper added a commit that referenced this issue Aug 13, 2015
@NickDraper
fix linux issue, missuing an include
b34d5b1 
re #11824
NickDraper added a commit that referenced this issue Aug 17, 2015
@NickDraper
Resolved first 2 issues
bbb2fab 
•	When I apply and save ROI to a workspace (or file) the region on the view is masked out instead.
•	When the save file dialog opens the cursor changes to "wait".

Final issue was present before (so was the 2nd) and needs a new issue creating

re #11824
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NickDraper NickDraper

Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a Region Of Interest mode to the Instrument view mantidproject/mantid
2 participants
@peterfpeterson @NickDraper