Add a Region Of Interest mode to the Instrument view

[NickDraper]

This adds a region of interest (ROI) mode to the instrument window.

This gathers together functionality from other modes, and add an intersection based view for applying ROIs.

This also changes the Mask/Group tab name to "draw" and the instrument tree tab name to "instrument".

fixes #11824

Documentation

The page http://www.mantidproject.org/MantidPlot:_Instrument_View has been updated

release notes

http://www.mantidproject.org/ReleaseNotes_3_5_UI_Changes#Instrument_View

To Test

1. Load up some data
2. Play around with adding masks, ROI's and groups, check the interplay between them.
3. Test the options under the Save or apply and save button in each mode.

[mantid-roman]

• When I apply and save ROI to a workspace (or file) the region on the view is masked out instead.
• When the save file dialog opens the cursor changes to "wait".
• I saved a ROI from a LOQ workspace to a file. Then I loaded it and masked the workspace with it. There were detectors I didn't select.

[NickDraper]

Thanks I’ll take another look

Regards,
Nick Draper

From: Roman Tolchenov [mailto:notifications@github.com]
Sent: 17 August 2015 10:11
To: mantidproject/mantid
Cc: Draper, Nick (-,RAL,ISIS)
Subject: Re: [mantid] Add a Region Of Interest mode to the Instrument view (#13374)

• When I apply and save ROI to a workspace (or file) the region on the view is masked out instead.
• When the save file dialog opens the cursor changes to "wait".
• I saved a ROI from a LOQ workspace to a file. Then I loaded it and masked the workspace with it. There were detectors I didn't select.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/13374#issuecomment-131739715.

[NickDraper]

The third issue we agreed after discussing it appears to be due to a mismatch of the instrument definintons used for LoadMask and Load for the dataset.

[mantid-roman]

The windows test failure seems unrelated.