Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Direct reduction scripts should not set the default instrument #11946

Closed
DanNixon opened this issue Feb 17, 2015 · 0 comments · Fixed by #14103
Closed

Direct reduction scripts should not set the default instrument #11946

DanNixon opened this issue Feb 17, 2015 · 0 comments · Fixed by #14103
Assignees
@abuts
Labels
Direct Inelastic Issues and pull requests related to direct inelastic

Comments

@DanNixon
Copy link
Member

This issue was originally TRAC 11107

For the same reasons as http://trac.mantidproject.org/mantid/ticket/11049.

In ReductionHelper.py:261 there is code that changes the default facility and instrument that should not need to.

You can loop over facilities using config.getFacilities() to find a given instrument.
@DanNixon DanNixon added the Direct Inelastic Issues and pull requests related to direct inelastic label Jun 3, 2015
abuts added a commit that referenced this issue Oct 23, 2015
@abuts
Re #11946 Should fix the issue
0a38672 
Though facility still should change
abuts added a commit that referenced this issue Oct 23, 2015
@abuts
Re #11946 Minor changes to test reduction
bf489ca 
to work with incorrect instrument
abuts added a commit that referenced this issue Oct 26, 2015
@abuts
Re #11946 This should fix the issue
69a6a62
abuts added a commit that referenced this issue Oct 26, 2015
@abuts
Re #11946 fixing RunDescriptorTest
f4d9239
abuts added a commit that referenced this issue Oct 26, 2015
@abuts
Re #11946 Pylint warnings
1b64449
abuts added a commit that referenced this issue Oct 27, 2015
@abuts
Re #11946 Fixing Mary system test for waiting for files
4aaebe6
abuts added a commit that referenced this issue Oct 27, 2015
@abuts
Re #11946 Should fix old LET reduction interface
4649cf2
@abuts abuts mentioned this issue Oct 27, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abuts abuts

Labels
Direct Inelastic Issues and pull requests related to direct inelastic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ISIS Reduction does not change instrument mantidproject/mantid
2 participants
@abuts @DanNixon