ISIS Reduction does not change instrument #14103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Though facility still should change
to work with incorrect instrument
abuts
added
Component: Python
Direct Inelastic
abuts
changed the title
|
Works well. All the ISISDirectInelastic tests pass, and after these changes the facility/instrument is not changed. |
FedeMPouzols
added a commit
that referenced
this pull request
Nov 2, 2015
…angeInstrument ISIS Reduction does not change instrument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11946
Its easy to test this ticket -- just change facility to e.g. SNS with any instrument and run a ISIS_Direct inelastic system test from Mantid. (e.g. Mantid\Testing\SystemTests\tests\analysis\ISIS_MariReduction.py -- the fastest one, either it passes or not on tester's machine (will fail if you do not have all files necessary for it to run) ) Before the changes after trying MARIReduction you will see facility changed to ISIS and instrument to MARI (for MARIReduction or appropriate for other ISIS direct instrument) No modification to default facility or instrument should happen after this change.
Changes to code is not so easy to follow as there were number of places where reduction was implicitly relying on default facility and instrument. The fact that system and unit tests pass give me confidence that I've identified and fixed all such places.
As the changes are entirely internal, I do not think any release note is necessary.