Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade a couple of warning/notice messages in FindPeaks to 'debug' level #12807

Closed
1 task
FedeMPouzols opened this issue Jun 12, 2015 · 1 comment · Fixed by #13079
Closed
1 task

Downgrade a couple of warning/notice messages in FindPeaks to 'debug' level #12807

FedeMPouzols opened this issue Jun 12, 2015 · 1 comment · Fixed by #13079
Assignees
@FedeMPouzols
Labels
Framework Issues and pull requests related to components in the Framework Low Priority Things that you don't ever want to be done.
Milestone
Release 3.5

Comments

@FedeMPouzols
Copy link
Contributor

These two messages:

Will show up when you run algorithms that use FindPeaks, like EnginXCalibrate for example. They should be 'debug' level. Also, check the messages logged by FindPeaks in general and make sure that there're no other too loud logs about details of the fitting.

This is 'blocked by'

(See also #806, where this was spotted from unrelated work on EnginXCalibrate).
@FedeMPouzols FedeMPouzols added Framework Issues and pull requests related to components in the Framework Fitting labels Jun 12, 2015
@FedeMPouzols FedeMPouzols added this to the Release 3.5 milestone Jun 12, 2015
@FedeMPouzols FedeMPouzols added the Low Priority Things that you don't ever want to be done. label Jun 12, 2015
@FedeMPouzols FedeMPouzols self-assigned this Jun 12, 2015
@NickDraper NickDraper added Framework Issues and pull requests related to components in the Framework and removed Framework Issues and pull requests related to components in the Framework labels Jun 30, 2015
FedeMPouzols added a commit that referenced this issue Jul 13, 2015
@FedeMPouzols
notice logs about fit parameters -> debug level, re #12807
1ef2aab
@FedeMPouzols FedeMPouzols mentioned this issue Jul 13, 2015
Merged
@peterfpeterson
Copy link
Member

There is the middle ground of information, but debug doesn't seem like a crazy choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FedeMPouzols FedeMPouzols

Labels
Framework Issues and pull requests related to components in the Framework Low Priority Things that you don't ever want to be done.
Projects
None yet
Milestone
Release 3.5
Development

Successfully merging a pull request may close this issue.

FindPeaks: logs about fit parameters, notice level -> debug level mantidproject/mantid
3 participants
@peterfpeterson @NickDraper @FedeMPouzols