FindPeaks: logs about fit parameters, notice level -> debug level #13079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedeMPouzols
added
the
Framework
peterfpeterson
added a commit
that referenced
this pull request
Jul 13, 2015
…ogs_to_debug_in_FindPeaks FindPeaks: logs about fit parameters, notice level -> debug level
rosswhitfield
deleted the
12807_downgrade_notice_logs_to_debug_in_FindPeaks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12807.
This simply changes the log level of a couple of log messages from FindPeaks that were initially added as too high level logs because of other issues which are now fixed (#12686).
To test:
This doesn't change functionality and absolutely does not need to go in the release notes.
@peterfpeterson : you might want to check or just be aware of this. I think that this should be fine as we planned some days ago, but feel free to revert or change as you need for FindPeaks development. After this I think that the verbosity level of FindPeaks is reasonable.