Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CrystalStructure should be stored in Sample #13905

Closed
MichaelWedel opened this issue Oct 8, 2015 · 0 comments
Closed

CrystalStructure should be stored in Sample #13905

MichaelWedel opened this issue Oct 8, 2015 · 0 comments
Assignees
@MichaelWedel
Labels
Diffraction Issues and pull requests related to diffraction Single Crystal Issues and pull requests related to single crystal
Milestone
Release 3.6

Comments

@MichaelWedel
Copy link
Contributor

With the modifications to CrystalStructure in #13537, it becomes feasible to add CrystalStructure to Sample, as it is easy to re-construct using information that can be stored in a Nexus-file.

This is split from #11268 to separate work.
@MichaelWedel MichaelWedel added Diffraction Issues and pull requests related to diffraction Single Crystal Issues and pull requests related to single crystal labels Oct 8, 2015
@MichaelWedel MichaelWedel self-assigned this Oct 8, 2015
@MichaelWedel MichaelWedel added this to the Release 3.6 milestone Oct 8, 2015
This was referenced Oct 8, 2015
Closed
Closed
Closed
MichaelWedel pushed a commit that referenced this issue Oct 16, 2015
Refs #13905. Added CrystalStructure to API::Sample
78f773d 
It's very similar to the way OrientedLattice is handled, except a unique_ptr is used to store the object.
MichaelWedel pushed a commit that referenced this issue Oct 16, 2015
Refs #13905. Checkpointing work
e22fe23
MichaelWedel pushed a commit that referenced this issue Oct 18, 2015
Refs #13905. First draft for IO-class
a21c59c
MichaelWedel pushed a commit that referenced this issue Oct 20, 2015
Refs #13905. Python exports and unit test.
d8c55e8
@MichaelWedel MichaelWedel mentioned this issue Oct 20, 2015
Merged
MichaelWedel pushed a commit that referenced this issue Oct 20, 2015
Refs #13905. Clang-format and VS2012 fix.
4600363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelWedel MichaelWedel

Labels
Diffraction Issues and pull requests related to diffraction Single Crystal Issues and pull requests related to single crystal
Projects
None yet
Milestone
Release 3.6
Development

No branches or pull requests
1 participant
@MichaelWedel