Extend PoldiFitPeaks2D so parameters can be tied #12762
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #12725.
Testing information
Code review. New option is covered by system test and unit test, documentation has been updated. For manual testing you could take this modified example from PoldiDataAnalysis:
If
TieProfileParameters
isTrue
, the plot should show a reasonable fit. If you change the value toFalse
, the result will look terrible. Looking at the workspacepoldi_data_6904_raw_fit_parameters
should contain the same value for allMixing
parameters (if ties are enabled), it should be close to 1 (0.86 +/- 0.065) on my machine.