Improve performance of rebin2D-type algorithms #12935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The points are now stored in a container rather than a custom linked-list. This will cut down on the the operations required to insert a new node. Refs #12584
This is just a simple forward iterator that doesn't implement the full iterator interface. Refs #12584
PoylgonIntersection uses new style of creating polygons. Refs #12584
Initial tests suggest this has given a factor of 2 improvement in speed. Refs #12584
martyngigg
added
In Progress
Framework
martyngigg
force-pushed
the
12584_rebin2d_performance_improvements
branch
from
6b5a5b0
to
3c2f089
Compare
Clang and MSVC both require the full definition to be able to use it as a member variable. Refs #12584
DanNixon
added a commit
that referenced
this pull request
Jun 29, 2015
…e_improvements Improve performance of rebin2D-type algorithms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12584
Tester
The script in the issue should now run much faster. On my machine the
SofQWalgorithm took ~130s to complete before these changes. It now takes ~15s. It should be noted that the code responsible for the polygon overlap calculation was improved first to give a ~50% speed improvement. The final improvement then came from re-enabling the OMP blocks to run the loop in parallel. It looks as if these were disabled for debugging but never re-enabled.The release notes have been updated.