Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instrument definition of IMAT #13178

Merged

Conversation

FedeMPouzols
Copy link
Contributor

Fixes #11068. This adds the 4 monitors that we currently have.
This also adds IMAT in the ISIS facility in the Facilities.xml file.
For now the only technique given in Facilities.xml is 'Neutron Imaging'. More will be added later on.

To test:

  • Verify that the changes to the instrument definition make sense. IMAT scientists are happy with the 4 monitor coordinates used, which are theoretical for now.
  • A simple manual test can be done with a couple of commands like this:
ws=Load('D:/IMAT_data/IMAT00000000.raw')
Integration(InputWorkspace=ws, OutputWorkspace='imat_integ')

(you can get the IMAT00000000.raw file from the ISIS instrument data, cycle_15_1, this is just a test data file). The second line should integrate the spectra for the 4 monitors.

Note that this does not yet add the second camera as it was originally planned months ago in the issue description. We are not there yet, but the update included in this pull request is what we need for now.

As many changes are and will be happening around IMAT in the next weeks, I'm not including this in the release notes for now. We'll have to revisit the IMAT news as a whole when we have a clear picture of all the new IMAT stuff that will go in the next release.

@FedeMPouzols FedeMPouzols added Diffraction Issues and pull requests related to diffraction Framework Issues and pull requests related to components in the Framework Component: Imaging labels Jul 22, 2015
@FedeMPouzols FedeMPouzols added this to the Release 3.5 milestone Jul 22, 2015
@DanNixon DanNixon self-assigned this Jul 23, 2015
@DanNixon
Copy link
Member

What exactly is at the "centre" of IMAT (or at least what will be there)?

I was confused as to why the IDF positions for the monitors are so different to the sample-detector distance in Mantid until I realised the sample position was ~20m away from the origin.

DanNixon added a commit that referenced this pull request Jul 23, 2015
…definition_IMAT_add_in_Facilities_file

Update instrument definition of IMAT
@DanNixon DanNixon merged commit 34b16a9 into master Jul 23, 2015
@DanNixon DanNixon deleted the 11068_update_instrument_definition_IMAT_add_in_Facilities_file branch July 23, 2015 13:37
@FedeMPouzols
Copy link
Contributor Author

@DanNixon : the origin/center of IMAT is approximately the leftmost place in this schematic: http://www.isis.stfc.ac.uk/images/instruments/imat/imat-design-outline14029.jpg. The 4 monitors that are used at this stage (well in the end they splitted them into 8 temporarily) are located: one before the chopper, the second one after it, the third one closer or inside the cabin before neutrons arrive at the detectors, and the last one after the detectors.

Good that you pointed this out, cause it may well be that the zero was defined in an unconventional way because of no particular reason. I will double-check with the IMAT crew.

@DanNixon
Copy link
Member

@FedeMPouzols Actually looking at the IDF it is obvious the "centre" is the source position.

It is probably fine as it is, I am just used to looking at spectrometers where the centre/origin is the sample position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction Framework Issues and pull requests related to components in the Framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants