Update instrument definition of IMAT #13178
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11068. This adds the 4 monitors that we currently have.
This also adds IMAT in the ISIS facility in the Facilities.xml file.
For now the only technique given in Facilities.xml is 'Neutron Imaging'. More will be added later on.
To test:
(you can get the
IMAT00000000.raw
file from the ISIS instrument data, cycle_15_1, this is just a test data file). The second line should integrate the spectra for the 4 monitors.Note that this does not yet add the second camera as it was originally planned months ago in the issue description. We are not there yet, but the update included in this pull request is what we need for now.
As many changes are and will be happening around IMAT in the next weeks, I'm not including this in the release notes for now. We'll have to revisit the IMAT news as a whole when we have a clear picture of all the new IMAT stuff that will go in the next release.