Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quasielastic fit functions with conv fit #13240

Merged
merged 26 commits into from
Jul 31, 2015
Merged

Quasielastic fit functions with conv fit #13240

merged 26 commits into from
Jul 31, 2015

Conversation

ElliotAOram
Copy link
Contributor

Fixes #12669

The ConvFit tab in indirect data analysis now allows for QuasiElastic functions to be used.
The code has also been changed from the previous hard coded approach to have a far better coverage for generalised code.

To test:

  • Open the Convfit tab (from the menu select: Interfaces>Indirect>Data Analysis then click the ConvFit tab)
  • Run any of the newly added QuasiElastic functions (selected in the FitType dropdown menu)
    • Load sample relevant data
    • Adjust parameters via the property tree
    • Click run
  • Check the output is as expected

Release notes updates here.

Elliot Oram added 16 commits July 17, 2015 11:15
Clang formatted and Doxygen coverage improved
6cd1886 
Refs #12669
Further update to Doxygen comments
282e0ad 
Refs #12669
Method stubs and menu items added for QuasiElastic fit
b0ac6b5 
Refs #12669
Initial work to display fit function parameters dynamically
86e8331 
Refs #12669
Fit Function parameters dynamically produced and displayed
80c9e36 
Refs #12669
Fit Function selection seperated in different tree groups
b13af80 
Refs #12669
Clang formatting and removal of redundant code
2529340 
Refs #12669
Refactored remove paramters from cftree method
b404c93 
Refs #12669
Hardcode removed in place of dynamic in singleFit
a415b46 
Refs #12669
Range bars added/removed as require for each fit
ed6dc07 
Refs #12669
Specific creation methods replaced with general method
37a21e2 
Refs #12669
Fit range bars automatically update cf_table contents
be7dfd5 
Refs #12669
Removed hardcode in favor of dynamic from createFunction
d79fed3 
Refs #12669
Fix run and single fit for Two Lorentzians
0915098 
Refs #12669
Set initial values for FWHM in Lorentz fits
09d7059 
Refs #12669
Clean up of test statements
693d348 
Refs #12669
@ElliotAOram ElliotAOram added the Indirect/Inelastic Issues and pull requests related to indirect or inelastic label Jul 29, 2015
@ElliotAOram ElliotAOram added this to the Release 3.5 milestone Jul 29, 2015
@DanNixon DanNixon self-assigned this Jul 29, 2015
@DanNixon
Copy link
Member

When fitting all spectra with StretchedExpFT I get: https://gist.github.com/DanNixon/79d7335782b4e7713421

@DanNixon
Copy link
Member

The only other issues I noticed:

  • Parameters not updated in plot menu when changing function
  • Exceptiion when switching to a function that cannot plot a guess when a guess is currently plotted

@ElliotAOram ElliotAOram changed the title 12669 quasielastic fit functions with conv fit Quasielastic fit functions with conv fit Jul 31, 2015
DanNixon added a commit that referenced this pull request Jul 31, 2015
@DanNixon
Merge pull request #13240 from mantidproject/12669_Quasielastic_fit_f…
3b7201f 
…unctions_with_ConvFit

Quasielastic fit functions with conv fit
@DanNixon DanNixon merged commit 3b7201f into master Jul 31, 2015
@DanNixon DanNixon deleted the 12669_Quasielastic_fit_functions_with_ConvFit branch July 31, 2015 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@DanNixon DanNixon

Labels
Indirect/Inelastic Issues and pull requests related to indirect or inelastic
Projects
None yet
Milestone
Release 3.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ElliotAOram @DanNixon