Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11534 calculate q resolution in Q1D #13312

Merged
merged 9 commits into from
Aug 13, 2015

Conversation

AntonPiccardoSelg
Copy link
Contributor

Fixes #11534

For Testing

Please find the required data here: \olympic\Babylon5\Scratch\Anton\Testing\11534_Calculate_Q1D_resolution\Q1D_Sandbox
The Windows installer: \olympic\Babylon5\Scratch\Anton\Testing\11534_Calculate_Q1D_resolution

The Sample Workspace is: det_bank_workspace.nxs
The WavePixelAdj workspace is: wave_adj.nxs
The outputBinning is: 0.001, -0.08, 1.0

There are tthree python scripts provided.
QResolution.py produces the QResolution workspace; QResolution_with_gravity.py does the same but with gravity correction enabled. Note that you have to specify the path to the data in the file
The script QResolutionEvaluate.py shows the sum of absolute values of the the DX values. Run this against the output of Q1D

Test that Q1D algorithm runs without QResolution

  1. Open Mantid and load det_bank_workspace.nxs and wave_adj.nxs
  2. Open the Alogrithm Q1D and set the following entries:
    • DetBankWorkspace
    • WavelengthAdj
      Don't set the rest
  3. Execute the algorithm
    • Confirm that no error occur
  4. Run the DX inspector script on the outputworkspace
    • Confirm that all outputs are 0

Test that Q1D algorithm runs withQResolution

  1. Open Mantid and load det_bank_workspace.nxs and wave_adj.nxs
  2. Run the python script QResolution.py
  3. Open the Alogrithm Q1D and set the following entries:
    • DetBankWorkspace
    • WavelengthAdj
    • QResolution to the newly generated workspace
  4. Execute the algorithm
    • Confirm that no error occur
  5. Run the DX inspector script on the outputworkspace
    • Confirm that some outputs are not 0

Test that Q1D algorithm runs withQResolution with_graivty enabled

  1. Open Mantid and load det_bank_workspace.nxs and wave_adj.nxs
  2. Run the python script QResolution_with_graivty_correction.py
  3. Open the Alogrithm Q1D and set the following entries:
    • DetBankWorkspace
    • WavelengthAdj
    • QResolution to the newly generated workspace
    • AccountForGravity = True
    • ExtraLength = 4
  4. Execute the algorithm
    • Confirm that no error occur
  5. Run the DX inspector script on the outputworkspace
    • Confirm that some outputs are not 0

@AntonPiccardoSelg AntonPiccardoSelg added State: In Progress Framework Issues and pull requests related to components in the Framework labels Aug 5, 2015
@AntonPiccardoSelg AntonPiccardoSelg added this to the Release 3.5 milestone Aug 5, 2015
Anders-Markvardsen added a commit that referenced this pull request Aug 13, 2015
…tion_in_Q1D

11534 calculate q resolution in Q1D
@Anders-Markvardsen Anders-Markvardsen merged commit 7103cc3 into master Aug 13, 2015
@Anders-Markvardsen Anders-Markvardsen deleted the 11534_calculate_q_resolution_in_Q1D branch August 13, 2015 06:47
@Anders-Markvardsen
Copy link
Member

Tests reproduced.

@picatess if you haven't done this already could you ask sans scientist to what extend they would like this enabled for Qxy also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants