Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formulas for statistics of peaks workspace #16198

Merged
merged 2 commits into from
May 14, 2016

Conversation

VickieLynch
Copy link
Contributor

Added latex formulas for values in statistics tables

To test:

build documentation and check for StatisticsOfPeaksWorkspace

Fixes #12651

Does not need to be in the release notes.


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • How do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant documentation been added/updated?
  • Is user-facing documentation written in a user-friendly manner?
  • Has developer documentation been updated if required?
  • Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.

@VickieLynch VickieLynch added Diffraction Issues and pull requests related to diffraction Single Crystal Issues and pull requests related to single crystal Quality: Documentation labels May 13, 2016
@VickieLynch VickieLynch added this to the Release 3.7 milestone May 13, 2016
@rosswhitfield rosswhitfield self-assigned this May 13, 2016
to by orientation (RunNumber) or by Anger camera (bank) or only do all peaks.
This algorithm call SortHKL, so more details are in the documentation for that algorithm.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can link to the SortHKL algorithm here by using :ref:algm-SortHKL``

@rosswhitfield
Copy link
Member

Looks good 👍 I didn't explicitly check the formulas but they look correct. :shipit:

@quantumsteve quantumsteve merged commit 7f68188 into master May 14, 2016
@rosswhitfield rosswhitfield deleted the 12651_statistics_formulas branch July 21, 2016 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction Single Crystal Issues and pull requests related to single crystal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants