Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade IPython on Windows #16742

Merged
merged 1 commit into from
Jul 19, 2016
Merged

Upgrade IPython on Windows #16742

merged 1 commit into from
Jul 19, 2016

Conversation

martyngigg
Copy link
Member

@martyngigg martyngigg commented Jun 27, 2016

Upgrades IPython to version 3.2.1

To test:

Windows only changes

  • Start MantidPlot and verify the IPython console is present and functioning.
  • Start the mantidpython script from the desktop and verify that IPython starts and functions correctly.
  • Start the IPython notebook link on the desktop and verify the kernel & browser start correctly.

Refs #13699

Does not need to be in the release notes.


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • How do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant documentation been added/updated?
  • Is user-facing documentation written in a user-friendly manner?
  • Has developer documentation been updated if required?
  • Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.

@martyngigg
Copy link
Member Author

@FedeMPouzols I know you've seen a few issues with the old version. Would you mind testing this one?

@FedeMPouzols
Copy link
Contributor

@martyngigg : sure, I'll have a look later today or tomorrow. Great that it was possible to fix these issues now!

@FedeMPouzols
Copy link
Contributor

FedeMPouzols commented Jul 5, 2016

The Python console works well as usual, both from MantidPlot and from the mantidplot script.
As for #13699, I can switch to the nbAgg backend in notebooks and I can see interactive plots (move around, zoom in/out, save (download)).

But I'm afraid this still crashes for me when I try to use tab autocompletion in the Python console of MantidPlot (as in #'13215):
debug_autocompl_assert

(compiled in debug mode with VS 2015 Update 2, on windows 7).

@martyngigg
Copy link
Member Author

martyngigg commented Jul 11, 2016

@FedeMPouzols Thanks for looking at this. I'm out of ideas of what to do with this now. As we are hopefully moving to Qt 5 in the not too-distant future should we merge this anyway as it enables the web backend for the IPython notebook to work?

@FedeMPouzols
Copy link
Contributor

@martyngigg: definitely yes. This change is good. I wouldn't worry much about the crash in debug mode. It seems to be a very persistent issue throughout several releases of several libraries.

This updates IPython on windows. All works well and now we can use interactive plots in notebooks (see comment above).
:shipit:

@martyngigg
Copy link
Member Author

martyngigg commented Jul 11, 2016

Thanks. I'll remove the fixes comments for those to crash issues.

@OwenArnold OwenArnold merged commit acb8998 into master Jul 19, 2016
@OwenArnold OwenArnold deleted the upgrade-ipython-win32 branch July 19, 2016 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants