Fix project modification notifications #17463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with application window sometimes not being notified when a workspace changes (for example when it is deleted). I also noticed that opening windows which are not MdiSubWindows will also cause the project to not appear modified.
To test:
This has been changed now so that everything the ADS notifies that it has been changed in MantidUI the project is marked as modified. Also when opening the slice viewer, instrument window, spectrum viewer, and VSI the project will be marked as modified (as they will now be serialised, see issues #16961, #16963, #17368, #17249
Fixes #11605 .
Does not need to be in the release notes.
Reviewer
Please comment on the following (full description):
Code Review
Functional Tests
@mantidproject/gatekeepers
will take care of it.This causes the project to appear as modified after the ADS changes or
after a window (including windows other than MdiSubWindows) are shown.