Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project modification notifications #17463

Merged
merged 1 commit into from
Sep 14, 2016

Conversation

samueljackson92
Copy link
Contributor

@samueljackson92 samueljackson92 commented Sep 12, 2016

There was an issue with application window sometimes not being notified when a workspace changes (for example when it is deleted). I also noticed that opening windows which are not MdiSubWindows will also cause the project to not appear modified.

To test:
This has been changed now so that everything the ADS notifies that it has been changed in MantidUI the project is marked as modified. Also when opening the slice viewer, instrument window, spectrum viewer, and VSI the project will be marked as modified (as they will now be serialised, see issues #16961, #16963, #17368, #17249

Fixes #11605 .

Does not need to be in the release notes.


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • How do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant documentation been added/updated?
  • Is user-facing documentation written in a user-friendly manner?
  • Has developer documentation been updated if required?
  • Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.

This causes the project to appear as modified after the ADS changes or
after a window (including windows other than MdiSubWindows) are shown.

This causes the project to appear as modified after the ADS changes or
after a window (including windows other than MdiSubWindows) are shown.
@samueljackson92 samueljackson92 added this to the Release 3.8 milestone Sep 12, 2016
@DavidFair DavidFair self-assigned this Sep 13, 2016
@DavidFair
Copy link
Contributor

This now correctly sets the modified attribute and prompts the user to save for the listed examples. :shipit:

@SimonHeybrock SimonHeybrock merged commit 47a159a into master Sep 14, 2016
@rosswhitfield rosswhitfield deleted the 11605_fix_project_modification_update branch September 14, 2016 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants