Indirect QuickRun - add diffusion option

[louisemccann]

EnergyWindowScan has been extended to include diffraction reduction and renamed to IndirectReductionAndAnalysis to better represent what the algorithm does.

To test:
InputFiles: Diff_inputs.zip

1
Interfaces>Indirect>Diffraction
Input: 26181
(this should find the appropriate run in the data archive otherwise browse to IRS26181 in files provided)
Ensure Instrument = ISIS and mode = diffspec
Press Run

2

IndirectReductionAndAnalysis(InputFiles='26176',
                             Instrument='IRIS',
                             Analyser='graphite',Reflection='002',
                             SpectraRange='3, 50',
                             ElasticRange='-0.5, 0',
                             InelasticRange='0, 0.5',
                             GroupingMethod='All',
                             MSDFit=False,
                             Diffraction=True,
                             DiffractionSpectraRange=[105,112])

Ensure irs26176_diffspec_red is the same for both methods

Fixes #18223 #12270

Release Notes

---

Reviewer

Please comment on the following (full description):

Code Review

• Is the code of an acceptable quality?
• Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
• Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
• If there are changes in the release notes then do they describe the changes appropriately?

Functional Tests

• Do changes function as described? Add comments below that describe the tests performed?

• How do the changes handle unexpected situations, e.g. bad input?

• Has the relevant documentation been added/updated?

• Is user-facing documentation written in a user-friendly manner?

• Has developer documentation been updated if required?

• Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.

[samueljackson92]

@louisemccann Question: EnergyWindowScan is already an algorithm in 3.9 right? So by renaming the algorithm to IndirectReductionAndAnalysis does this break the Python API? EnergyWindowScan is pretty niche, but shouldn't we deprecate for a version then remove?

One option would be to just point the deprecated EnergyWindowScan at the new algorithm.

[samueljackson92]

All of the stuff under the if statement could be refactored into a method.

[samueljackson92]

In fact I'd go for one method per algorithm i.e. something like self.run_diffraction_reduction(), self.run_msg() ...

[samueljackson92]

See suggested changes above, or come talk to me if you disagree.

[SpencerHowells]

We need EnergyWindowScan for use by the Interface in #18216

[samueljackson92]

@SpencerHowells I agree the algorithm needs to exist. My problem is with renaming. Renaming would potentially break any user scripts that we have no control over that use the current name. Hence we should really deprecate the name EnergyWindowScan for one version of Mantid, then remove any reference of the algorithm called EnergyWindowScan in favour of IndirectReductionAndAnalysis.

[louisemccann]

It has been decided that EnergyWindowScan and the DiffractionScan should be 2 different algs so I am going to close this.