Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed extra blank page on print all plots #20043

Merged
merged 2 commits into from
Jul 21, 2017

Conversation

MatthewBowles
Copy link
Contributor

Fixed an issue when using File->Print All Plots where an extra blank page would be printed.

To test:

  • Create/load some workspaces
  • Plot multiple spectra plots
  • File > Print All Plots
  • Select Print To File (PDF)
  • Print
  • Open the file and check there are no blank pages

Fixes #11606

Release Notes

Does not need to be in the release notes.


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

@PranavBahuguna PranavBahuguna self-assigned this Jul 20, 2017
@PranavBahuguna PranavBahuguna self-requested a review July 20, 2017 13:14
Copy link
Contributor

@PranavBahuguna PranavBahuguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and changes work as expected 👍

:shipit: once checks pass

@martyngigg martyngigg self-assigned this Jul 21, 2017
@martyngigg martyngigg merged commit 671e3d3 into master Jul 21, 2017
@martyngigg martyngigg deleted the 11606_print_all_blank_page branch July 21, 2017 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants