Skip to content

Commit

Permalink
Temp fix to inability to disable notifications
Browse files Browse the repository at this point in the history
The proper fix for this is not trivial involving database schema change, localization, etc.
Until this is done, we will treat uncustomizable notifications the same way as the
default preference where the "email_on_status" preference is used.
The issue will not be marked as resolved until we add the necessary preferences.
However, we should consider a model where adding user preferences doesn't
require a schema change.

Issue #19459
  • Loading branch information
vboctor committed Mar 10, 2015
1 parent 7e188bc commit 0298961
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions core/email_api.php
Expand Up @@ -337,12 +337,10 @@ function email_collect_recipients( $p_bug_id, $p_notify_type, array $p_extra_use
case 'relation':
case 'monitor':
case 'priority': # This is never used, but exists in the database!
# FIXME: these notification actions are not actually implemented
# Issue #19459 these notification actions are not actually implemented
# in the database and therefore aren't adjustable on a per-user
# basis! The exception is 'monitor' that makes no sense being a
# customisable per-user preference.
$t_pref_field = false;
break;
default:
# Anything not built-in is probably going to be a status
$t_pref_field = 'email_on_status';
Expand Down

0 comments on commit 0298961

Please sign in to comment.