Fix PHPStorm warnings in plugin_api.php

mantisbt · Sep 25, 2020 · 49719d8 · 49719d8
1 parent f55f87e
commit 49719d8
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/core/database_api.php b/core/database_api.php
@@ -37,11 +37,16 @@
 require_api( 'logging_api.php' );
 require_api( 'utility_api.php' );
 
+/**
+ * Main database connection.
+ * @var ADOConnection $g_db
+ */
+$g_db = false;
+
 # An array in which all executed queries are stored.  This is used for profiling
 # @global array $g_queries_array
 $g_queries_array = array();
 
-
 # Stores whether a database connection was successfully opened.
 # @global bool $g_db_connected
 $g_db_connected = false;

diff --git a/core/plugin_api.php b/core/plugin_api.php
@@ -624,20 +624,19 @@ function plugin_is_installed( $p_basename ) {
 /**
  * Install a plugin to the database.
  * @param MantisPlugin $p_plugin Plugin basename.
- * @return null
+ * @return void
  */
 function plugin_install( MantisPlugin $p_plugin ) {
 	if( plugin_is_installed( $p_plugin->basename ) ) {
 		error_parameters( $p_plugin->basename );
 		trigger_error( ERROR_PLUGIN_ALREADY_INSTALLED, WARNING );
-		return null;
 	}
 
 	plugin_push_current( $p_plugin->basename );
 
 	if( !$p_plugin->install() ) {
 		plugin_pop_current();
-		return null;
+		return;
 	}
 
 	db_param_push();
@@ -701,6 +700,7 @@ function plugin_upgrade( MantisPlugin $p_plugin ) {
 			plugin_pop_current();
 			return false;
 		}
+		$t_status = false;
 
 		switch( $t_schema[$i][0] ) {
 			case 'InsertData':
@@ -735,7 +735,6 @@ function plugin_upgrade( MantisPlugin $p_plugin ) {
 					array( $t_dict, $t_schema[$i][0] ),
 					$t_schema[$i][1]
 				);
-				$t_status = false;
 		}
 
 		if( $t_sqlarray ) {
@@ -829,6 +828,7 @@ function plugin_include( $p_basename, $p_child = null ) {
 	}
 	$t_included = false;
 	if( is_file( $t_plugin_file ) ) {
+		/** @noinspection PhpIncludeInspection */
 		include_once( $t_plugin_file );
 		$t_included = true;
 	}
@@ -851,6 +851,7 @@ function plugin_require_api( $p_file, $p_basename = null ) {
 
 	$t_path = config_get_global( 'plugin_path' ) . $t_current . '/';
 
+	/** @noinspection PhpIncludeInspection */
 	require_once( $t_path . $p_file );
 }