Skip to content

Commit

Permalink
Fix #11600: Bugnote direct links include mismatched parenthesis
Browse files Browse the repository at this point in the history
In the bugnote direct links in the left column of the "Notes" section of
an issue page, the right parenthesis is part of the link but the left
parenthesis is not.

This patch removes the parenthesis entirely and instead uses the value
of $g_bugnote_link_tag as a prefix to the bugnote ID. This technique is
a subtle reminder to users of the syntax to use within bugnotes and bug
descriptions to refer to a particular bugnote.
  • Loading branch information
davidhicks committed Mar 4, 2010
1 parent 6dd6e7c commit 4f3906f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bugnote_view_inc.php
Expand Up @@ -154,7 +154,7 @@
<tr class="bugnote" id="c<?php echo $t_bugnote->id ?>">
<td class="<?php echo $t_bugnote_css ?>">
<?php if ( ON == config_get("show_avatar") ) print_avatar( $t_bugnote->reporter_id ); ?>
<span class="small">(<a href="<?php echo string_get_bugnote_view_url($t_bugnote->bug_id, $t_bugnote->id) ?>" title="<?php echo lang_get( 'bugnote_link_title' ) ?>"><?php echo $t_bugnote_id_formatted ?>)</a></span><br />
<span class="small"><a href="<?php echo string_get_bugnote_view_url($t_bugnote->bug_id, $t_bugnote->id) ?>" title="<?php echo lang_get( 'bugnote_link_title' ) ?>"><?php echo htmlentities( config_get_global( 'bugnote_link_tag' ) ) . $t_bugnote_id_formatted ?></a></span><br />
<?php
echo print_user( $t_bugnote->reporter_id );
?>
Expand Down

0 comments on commit 4f3906f

Please sign in to comment.