Fix #12549: Bug change status form always creates private bug notes

Due to invalid handling of boolean types and built in view state
constants, bug notes added via the bug change status form were ignoring
the "private" checkbox.

Signed-off-by: David Hicks <hickseydr@optusnet.com.au>

bug_update.php

@@ -123,7 +123,7 @@
 
 $t_bug_note = new BugNoteData();
 $t_bug_note->note = gpc_get_string( 'bugnote_text', '' );
-$t_bug_note->view_state = gpc_get_bool( 'private', config_get( 'default_bugnote_view_status' ) );
+$t_bug_note->view_state = gpc_get_bool( 'private', config_get( 'default_bugnote_view_status' ) == VS_PRIVATE ) ? VS_PRIVATE : VS_PUBLIC;
 $t_bug_note->time_tracking = gpc_get_string( 'time_tracking', '0:00' );
 
 # Determine whether the new status will reopen, resolve or close the issue.
@@ -358,7 +358,7 @@
 
 # Add a bug note if there is one.
 if ( $t_bug_note->note || helper_duration_to_minutes( $t_bug_note->time_tracking ) > 0 ) {
-	bugnote_add( $f_bug_id, $t_bug_note->note, $t_bug_note->time_tracking, $t_bug_note->view_state, 0, '', null, false );
+	bugnote_add( $f_bug_id, $t_bug_note->note, $t_bug_note->time_tracking, $t_bug_note->view_state == VS_PRIVATE, 0, '', null, false );
 }
 
 # Add a duplicate relationship if requested.