Bug #11826 - Remove inline javascript for bug-jump field and put it i…

…n common.js. Add

css styles for bug-jump.

core/html_api.php

@@ -865,15 +865,12 @@ function print_menu() {
 		echo '</ul>';
 		echo '</div>';
 		echo '<div class="bug-jump">';
-		echo '<form method="post" action="' . helper_mantis_url( 'jump_to_bug.php">' );
+		echo '<form method="post" action="' . helper_mantis_url( 'jump_to_bug.php" class="bug-jump-form">' );
 		# CSRF protection not required here - form does not result in modifications
 
-		if( ON == config_get( 'use_javascript' ) ) {
-			$t_bug_label = lang_get( 'issue_id' );
-			echo "<input type=\"text\" name=\"bug_id\" size=\"10\" class=\"small\" value=\"$t_bug_label\" onfocus=\"if (this.value == '$t_bug_label') this.value = ''\" onblur=\"if (this.value == '') this.value = '$t_bug_label'\" />&nbsp;";
-		} else {
-			echo "<input type=\"text\" name=\"bug_id\" size=\"10\" class=\"small\" />&nbsp;";
-		}
+		$t_bug_label = lang_get( 'issue_id' );
+		echo '<input type="hidden" name="bug_label" value="', $t_bug_label, '" />';
+		echo '<input type="text" name="bug_id" size="10" class="small" />&nbsp;';
 
 		echo '<input type="submit" class="button-small" value="' . lang_get( 'jump' ) . '" />&nbsp;';
 		echo '</form>';

css/default.css

@@ -111,7 +111,8 @@ td.login-info-right		{ width: 33%; padding: 0px; text-align: right; white-space:
 #content { clear: both; margin: 0; padding: .5em; }
 br { clear:both; }
 
-.bug-jump { position: relative; top: -2.5em; right: .5em; float: right;  }
+.bug-jump { position: relative; top: -2.5em; right: .5em; float: right;  z-index: 100; }
+.field-default { color: #999; }
 
 td.menu
 {

javascript/common.js

@@ -147,8 +147,34 @@ $(document).ready( function() {
 			button: element.id + '_datetime_button'
 		});
 	});
+
+
+	$('.bug-jump').find('[name=bug_id]').focus( function() {
+		var bug_label = $('.bug-jump-form').find('[name=bug_label]').val();
+		if( $(this).val() == bug_label ) {
+			$(this).val('');
+			$(this).removeClass('field-default');
+		}
+	});
+	$('.bug-jump').find('[name=bug_id]').blur( function() {
+		var bug_label = $('.bug-jump-form').find('[name=bug_label]').val();
+		if( $(this).val() == '' ) {
+			$(this).val(bug_label);
+			$(this).addClass('field-default');
+		}
+	});
+	setBugLabel();
 });
 
+function setBugLabel() {
+	var bug_label = $('.bug-jump-form').find('[name=bug_label]').val();
+	var field = $('.bug-jump').find('[name=bug_id]');
+	if( field.val() == '' ) {
+		field.val(bug_label);
+		field.addClass('field-default');
+	}
+}
+
 /*
  * String manipulation
  */

javascript/dev/common.js

@@ -151,8 +151,34 @@ $(document).ready( function() {
 			button: element.id + '_datetime_button'
 		});
 	});
+
+
+	$('.bug-jump').find('[name=bug_id]').focus( function() {
+		var bug_label = $('.bug-jump-form').find('[name=bug_label]').val();
+		if( $(this).val() == bug_label ) {
+			$(this).val('');
+			$(this).removeClass('field-default');
+		}
+	});
+	$('.bug-jump').find('[name=bug_id]').blur( function() {
+		var bug_label = $('.bug-jump-form').find('[name=bug_label]').val();
+		if( $(this).val() == '' ) {
+			$(this).val(bug_label);
+			$(this).addClass('field-default');
+		}
+	});
+	setBugLabel();
 });
 
+function setBugLabel() {
+	var bug_label = $('.bug-jump-form').find('[name=bug_label]').val();
+	var field = $('.bug-jump').find('[name=bug_id]');
+	if( field.val() == '' ) {
+		field.val(bug_label);
+		field.addClass('field-default');
+	}
+}
+
 /*
  * String manipulation
  */