Skip to content

Commit

Permalink
Fixes #11061: SOAP issue tests fail
Browse files Browse the repository at this point in the history 
Values not passed to mc_issue_add or mc_issue_update now have values
set to default.

According to vboctor at one point methods like mci_get_user_id() were taking
a reference (&) and the isset check was within the method. At one point
such references were removed causing the parameter to be evaluated while
it is not set.
  • Loading branch information
@rombert @vboctor
rombert authored and vboctor committed Oct 22, 2009
1 parent 9e0b5d6 commit ef8e2a3
Showing 1 changed file with 24 additions and 24 deletions.
48 changes: 24 additions & 24 deletions api/soap/mc_issue_api.php
View file
Expand Up @@ -415,19 +415,19 @@ function mc_issue_add( $p_username, $p_password, $p_issue ) {
return new soap_fault( 'Client', '', 'Access Denied' );
}

$t_handler_id = mci_get_user_id( $p_issue['handler'] );
$t_priority_id = mci_get_priority_id( $p_issue['priority'] );
$t_severity_id = mci_get_severity_id( $p_issue['severity'] );
$t_status_id = mci_get_status_id( $p_issue['status'] );
$t_reproducibility_id = mci_get_reproducibility_id( $p_issue['reproducibility'] );
$t_resolution_id = mci_get_resolution_id( $p_issue['resolution'] );
$t_projection_id = mci_get_projection_id( $p_issue['projection'] );
$t_eta_id = mci_get_eta_id( $p_issue['eta'] );
$t_view_state_id = mci_get_view_state_id( $p_issue['view_state'] );
$t_reporter_id = mci_get_user_id( $p_issue['reporter'] );
$t_handler_id = isset( $p_issue['handler'] ) ? mci_get_user_id( $p_issue['handler'] ) : 0;
$t_priority_id = isset( $p_issue['priority'] ) ? mci_get_priority_id( $p_issue['priority'] ) : config_get( 'default_bug_priority' );
$t_severity_id = isset( $p_issue['severity'] ) ? mci_get_severity_id( $p_issue['severity'] ) : config_get( 'default_bug_severity' );
$t_status_id = isset ( $p_issue['status'] ) ? mci_get_status_id( $p_issue['status'] ) : config_get( 'bug_submit_status' );
$t_reproducibility_id = isset ( $p_issue['reproducibility'] ) ? mci_get_reproducibility_id( $p_issue['reproducibility'] ) : config_get( 'default_bug_reproducibility' );
$t_resolution_id = isset ( $p_issue['resolution'] ) ? mci_get_resolution_id( $p_issue['resolution'] ) : config_get('default_bug_resolution');
$t_projection_id = isset ( $p_issue['projection'] ) ? mci_get_projection_id( $p_issue['projection'] ) : config_get('default_bug_resolution');
$t_eta_id = isset ( $p_issue['eta'] ) ? mci_get_eta_id( $p_issue['eta'] ) : config_get('default_bug_eta');
$t_view_state_id = isset ( $p_issue['view_state'] ) ? mci_get_view_state_id( $p_issue['view_state'] ) : config_get( 'default_bug_view_status' );
$t_reporter_id = isset ( $p_issue['reporter'] ) ? mci_get_user_id( $p_issue['reporter'] ) : 0;
$t_summary = $p_issue['summary'];
$t_description = $p_issue['description'];
$t_notes = $p_issue['notes'];
$t_notes = isset ( $p_issue['notes'] ) ? $p_issue['notes'] : array();

if( $t_reporter_id == 0 ) {
$t_reporter_id = $t_user_id;
Expand Down Expand Up @@ -581,20 +581,20 @@ function mc_issue_update( $p_username, $p_password, $p_issue_id, $p_issue ) {

$t_project_id = mci_get_project_id( $p_issue['project'] );
$t_handler_id = isset( $p_issue['handler'] ) ? mci_get_user_id( $p_issue['handler'] ) : 0;
$t_priority_id = mci_get_priority_id( $p_issue['priority'] );
$t_severity_id = mci_get_severity_id( $p_issue['severity'] );
$t_status_id = mci_get_status_id( $p_issue['status'] );
$t_reproducibility_id = mci_get_reproducibility_id( $p_issue['reproducibility'] );
$t_resolution_id = mci_get_resolution_id( $p_issue['resolution'] );
$t_projection_id = mci_get_projection_id( $p_issue['projection'] );
$t_eta_id = mci_get_eta_id( $p_issue['eta'] );
$t_view_state_id = mci_get_view_state_id( $p_issue['view_state'] );
$t_reporter_id = mci_get_user_id( $p_issue['reporter'] );
$t_priority_id = isset( $p_issue['priority'] ) ? mci_get_priority_id( $p_issue['priority'] ) : config_get( 'default_bug_priority' );
$t_severity_id = isset( $p_issue['severity'] ) ? mci_get_severity_id( $p_issue['severity'] ) : config_get( 'default_bug_severity' );
$t_status_id = isset ( $p_issue['status'] ) ? mci_get_status_id( $p_issue['status'] ) : config_get( 'bug_submit_status' );
$t_reproducibility_id = isset ( $p_issue['reproducibility'] ) ? mci_get_reproducibility_id( $p_issue['reproducibility'] ) : config_get( 'default_bug_reproducibility' );
$t_resolution_id = isset ( $p_issue['resolution'] ) ? mci_get_resolution_id( $p_issue['resolution'] ) : config_get('default_bug_resolution');
$t_projection_id = isset ( $p_issue['projection'] ) ? mci_get_projection_id( $p_issue['projection'] ) : config_get('default_bug_resolution');
$t_eta_id = isset ( $p_issue['eta'] ) ? mci_get_eta_id( $p_issue['eta'] ) : config_get('default_bug_eta');
$t_view_state_id = isset ( $p_issue['view_state'] ) ? mci_get_view_state_id( $p_issue['view_state'] ) : config_get( 'default_bug_view_status' );
$t_reporter_id = isset ( $p_issue['reporter'] ) ? mci_get_user_id( $p_issue['reporter'] ) : 0;
$t_project = $p_issue['project'];
$t_summary = $p_issue['summary'];
$t_description = $p_issue['description'];
$t_additional_information = $p_issue['additional_information'];
$t_steps_to_reproduce = $p_issue['steps_to_reproduce'];
$t_summary = isset ( $p_issue['summary'] ) ? $p_issue['summary'] : '';
$t_description = isset ( $p_issue['description'] ) ? $p_issue['description'] : '';
$t_additional_information = isset ( $p_issue['additional_information'] ) ? $p_issue['additional_information'] : '';
$t_steps_to_reproduce = isset ( $p_issue['steps_to_reproduce'] ) ? $p_issue['steps_to_reproduce'] : '';

if( $t_reporter_id == 0 ) {
$t_reporter_id = $t_user_id;
Expand Down

0 comments on commit ef8e2a3

Please sign in to comment.