Skip to content

Commit

Permalink
Fixes #11320: Provide a way to disable the raw configuration management.
Browse files Browse the repository at this point in the history
  • Loading branch information
@vboctor
vboctor committed Jan 4, 2010
1 parent e8d9738 commit fce04e6
Show file tree
Hide file tree
Showing 7 changed files with 70 additions and 17 deletions.
8 changes: 4 additions & 4 deletions adm_config_delete.php
View file
Expand Up @@ -31,10 +31,10 @@
$f_project_id = gpc_get_int( 'project_id' );
$f_config_option = gpc_get_string( 'config_option' );

if ( $f_project_id == ALL_PROJECTS ) {
access_ensure_global_level( config_get( 'set_configuration_threshold' ) );
} else {
access_ensure_project_level( config_get( 'set_configuration_threshold' ), $f_project_id );
access_ensure_global_level( config_get( 'set_configuration_threshold' ) );

if ( $f_project_id != ALL_PROJECTS ) {
project_ensure_exists( $f_project_id );
}

helper_ensure_confirmed( lang_get( 'delete_config_sure_msg' ), lang_get( 'delete_link' ) );
Expand Down
10 changes: 8 additions & 2 deletions adm_config_report.php
View file
Expand Up @@ -25,7 +25,9 @@
*/
require_once( 'core.php' );

access_ensure_project_level( config_get( 'view_configuration_threshold' ) );
access_ensure_global_level( config_get( 'view_configuration_threshold' ) );

$t_read_write_access = access_has_global_level( config_get('set_configuration_threshold' ) );

html_page_top( lang_get( 'configuration_report' ) );

Expand Down Expand Up @@ -121,9 +123,11 @@ function print_config_value_as_string( $p_type, $p_value ) {
<td class="center">
<?php echo lang_get( 'access_level' ) ?>
</td>
<?php if ( $t_read_write_access ): ?>
<td class="center">
<?php echo lang_get( 'actions' ) ?>
</td>
<?php endif; ?>
</tr>
<?php
while ( $row = db_fetch_array( $result ) ) {
Expand All @@ -150,6 +154,7 @@ function print_config_value_as_string( $p_type, $p_value ) {
<td class="center">
<?php echo get_enum_element( 'access_levels', $v_access_reqd ) ?>
</td>
<?php if ( $t_read_write_access ): ?>
<td class="center">
<?php
if ( config_can_delete( $v_config_id ) ) {
Expand All @@ -159,13 +164,14 @@ function print_config_value_as_string( $p_type, $p_value ) {
}
?>
</td>
<?php endif; ?>
</tr>
<?php
} # end for loop
?>
</table>
<?php
if ( access_has_global_level( config_get('set_configuration_threshold' ) ) ) {
if ( $t_read_write_access ) {
?>
<br />
<!-- Config Set Form -->
Expand Down
7 changes: 3 additions & 4 deletions adm_config_set.php
View file
Expand Up @@ -40,11 +40,10 @@
trigger_error( ERROR_EMPTY_FIELD, ERROR );
}

if ( $f_project_id == ALL_PROJECTS ) {
access_ensure_global_level( config_get('set_configuration_threshold' ) );
} else {
access_ensure_global_level( config_get( 'set_configuration_threshold' ) );

if ( $f_project_id != ALL_PROJECTS ) {
project_ensure_exists( $f_project_id );
access_ensure_project_level( config_get('set_configuration_threshold' ), $f_project_id );
}

# make sure that configuration option specified is a valid one.
Expand Down
2 changes: 1 addition & 1 deletion adm_permissions_report.php
View file
Expand Up @@ -26,7 +26,7 @@
*/
require_once( 'core.php' );

access_ensure_project_level( config_get( 'view_configuration_threshold' ) );
access_ensure_project_level( config_get( 'manage_configuration_threshold' ) );

html_page_top( lang_get( 'permissions_summary_report' ) );

Expand Down
6 changes: 6 additions & 0 deletions config_defaults_inc.php
View file
Expand Up @@ -2762,6 +2762,12 @@
*/
$g_csv_separator = ',';

/**
* The threshold required for users to be able to manage configuration of a project.
* This includes workflow, email notifications, columns to view, and others.
*/
$g_manage_configuration_threshold = MANAGER;

/**
* threshold for users to view the system configurations
* @global int $g_view_configuration_threshold
Expand Down
28 changes: 22 additions & 6 deletions core/html_api.php
View file
Expand Up @@ -926,6 +926,7 @@ function print_manage_menu( $p_page = '' ) {
$t_manage_custom_field_page = 'manage_custom_field_page.php';
$t_manage_plugin_page = 'manage_plugin_page.php';
$t_manage_config_page = 'adm_config_report.php';
$t_permissions_summary_report = 'adm_permissions_report.php';
$t_manage_prof_menu_page = 'manage_prof_menu_page.php';
$t_manage_tags_page = 'manage_tags_page.php';

Expand All @@ -942,6 +943,9 @@ function print_manage_menu( $p_page = '' ) {
case $t_manage_config_page:
$t_manage_config_page = '';
break;
case $t_permissions_summary_report:
$t_permissions_summary_report = '';
break;
case $t_manage_plugin_page:
$t_manage_plugin_page = '';
break;
Expand Down Expand Up @@ -972,8 +976,15 @@ function print_manage_menu( $p_page = '' ) {
if( access_has_global_level( config_get( 'manage_plugin_threshold' ) ) ) {
print_bracket_link( helper_mantis_url( $t_manage_plugin_page ), lang_get( 'manage_plugin_link' ) );
}
if( access_has_project_level( config_get( 'view_configuration_threshold' ) ) ) {
print_bracket_link( helper_mantis_url( $t_manage_config_page ), lang_get( 'manage_config_link' ) );

if ( access_has_project_level( config_get( 'manage_configuration_threshold' ) ) ) {
if ( access_has_global_level( config_get( 'view_configuration_threshold' ) ) ) {
$t_config_page = $t_manage_config_page;
} else {
$t_config_page = $t_permissions_summary_report;
}

print_bracket_link( helper_mantis_url( $t_config_page ), lang_get( 'manage_config_link' ) );
}

# Plugin / Event added options
Expand Down Expand Up @@ -1034,16 +1045,21 @@ function print_manage_config_menu( $p_page = '' ) {
break;
}

echo '<br /><div align="center">';
if( access_has_project_level( config_get( 'view_configuration_threshold' ) ) ) {
print_bracket_link( helper_mantis_url( $t_configuration_report ), lang_get_defaulted( 'configuration_report' ) );
if ( access_has_project_level( config_get( 'manage_configuration_threshold' ) ) ) {
echo '<br /><div align="center">';

if ( access_has_global_level( config_get( 'view_configuration_threshold' ) ) ) {
print_bracket_link( helper_mantis_url( $t_configuration_report ), lang_get_defaulted( 'configuration_report' ) );
}

print_bracket_link( helper_mantis_url( $t_permissions_summary_report ), lang_get( 'permissions_summary_report' ) );
print_bracket_link( helper_mantis_url( $t_manage_work_threshold ), lang_get( 'manage_threshold_config' ) );
print_bracket_link( helper_mantis_url( $t_manage_workflow ), lang_get( 'manage_workflow_config' ) );
print_bracket_link( helper_mantis_url( $t_manage_email ), lang_get( 'manage_email_config' ) );
print_bracket_link( $t_manage_columns, lang_get( 'manage_columns_config' ) );

echo '</div>';
}
echo '</div>';
}

/**
Expand Down
26 changes: 26 additions & 0 deletions docbook/adminguide/en/configuration.sgml
View file
Expand Up @@ -2206,6 +2206,32 @@
</warning>
</listitem>
</varlistentry>
<varlistentry>
<term>$g_manage_configuration_threshold</term>
<listitem>
<para>The threshold required for users to be able to manage configuration of a project.
This includes workflow, email notifications, columns to view, and others. Default is MANAGER.
</para>
</listitem>
</varlistentry>
<varlistentry>
<term>$g_view_configuration_threshold</term>
<listitem>
<para>Threshold for users to view the raw system configurations as stored in the database.
Default is DEVELOPER.
</para>
</listitem>
</varlistentry>
<varlistentry>
<term>$g_set_configuration_threshold</term>
<listitem>
<para>Threshold for users to set the system configurations generically via MantisBT web interface.
WARNING: Users who have access to set configuration via the interface MUST be trusted. This is due
to the fact that such users can set configurations to PHP code and hence there can be a security
risk if such users are not trusted.
</para>
</listitem>
</varlistentry>
</variablelist>
</section>

Expand Down

0 comments on commit fce04e6

Please sign in to comment.