New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE: fix blockquote code continuation and add space token after #3264
Open
UziTech
wants to merge
4
commits into
markedjs:master
Choose a base branch
from
UziTech:blockquote-test
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
UziTech
force-pushed
the
blockquote-test
branch
from
April 20, 2024 23:27
a4980a7
to
a988a86
Compare
UziTech
force-pushed
the
blockquote-test
branch
from
April 20, 2024 23:45
a988a86
to
701a86d
Compare
UziTech
changed the title
test blockquote
fix: fix blockquote code continuation and add space token after
Apr 21, 2024
UziTech
changed the title
fix: fix blockquote code continuation and add space token after
BREAKING CHANGE: fix blockquote code continuation and add space token after
Apr 22, 2024
UziTech
requested review from
styfle,
joshbruce,
davisjam and
calculuschild
and removed request for
calculuschild
April 22, 2024 04:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version: 12.0.2
Description
Fix blockquote continuation for code blocks
Fixes CommonMark #236
Fixes CommonMark #237
also adds space token after blockquote and hr if there are multiple newlines. fixes #3167.
I believe this will be a breaking change since tokens will change even though the output won't change.
Contributor
Committer
In most cases, this should be a different person than the contributor.