Fix propagation of "partial" to Nested containers #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafrech
force-pushed
the
propagate_partial_to_nested_containers
branch
from
5a57d5a
to
fe85631
Compare
|
I added tests and fixed the fix. There might be a slight performance penalty when partial is a collection as the "remove prefix" logic is executed for all fields, not only There will be a merge conflict with #1229 in test_fields.py. I can rebase when the first of the two is merged. |
sloria
approved these changes
Jun 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix passing
partialtoNestedcontainers.This passes the test case provided in #779 (comment) and does not break any other test.
I didn't think much about the implications.
TODO: