Skip to content

Commit

Permalink
Avoid losing previous values on static variables
Browse files Browse the repository at this point in the history
If we initialize each time the variable, we lose previous changes, so for
example cache variables are retrieved every call.
  • Loading branch information
marvil07 committed Jul 10, 2009
1 parent 1a753cd commit e847e49
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 3 deletions.
3 changes: 3 additions & 0 deletions versioncontrol-backend.inc
Expand Up @@ -161,6 +161,9 @@ function versioncontrol_get_access_errors() {
*/
function _versioncontrol_access_errors($new_messages = NULL) {
static $error_messages = array();
if (!isset($error_messages)) {
$error_messages = array();
}

if (isset($new_messages)) {
$error_messages = $new_messages;
Expand Down
15 changes: 12 additions & 3 deletions versioncontrol.module
Expand Up @@ -677,7 +677,10 @@ function versioncontrol_get_repository($repo_id) {
* an empty array is returned.
*/
function versioncontrol_get_repositories($constraints = array()) {
static $repository_cache = array();
static $repository_cache;
if (!isset($repository_cache)) {
$repository_cache = array();
}

$backends = versioncontrol_get_backends();
$auth_methods = versioncontrol_get_authorization_methods();
Expand Down Expand Up @@ -1353,7 +1356,10 @@ function _versioncontrol_construct_operation_query(&$constraints, &$tables) {
* elements 'callback' and 'cardinality'.
*/
function _versioncontrol_operation_constraint_info() {
static $constraint_info = array();
static $constraint_info;
if (!isset($constraint_info)) {
$constraint_info = array();
}

if (empty($constraint_info)) {
foreach (module_implements('versioncontrol_operation_constraint_info') as $module) {
Expand Down Expand Up @@ -3032,7 +3038,10 @@ function versioncontrol_get_url_tracker($repository, $issue_id) {
* - 'tracker': The issue/bug/case URL of the associated issue tracker.
*/
function _versioncontrol_get_repository_urls($repository) {
static $urls_by_repository = array();
static $urls_by_repository;
if (!isset($urls_by_repository)) {
$urls_by_repository = array();
}

if (!isset($urls_by_repository[$repository['repo_id']])) {
$result = db_query('SELECT * FROM {versioncontrol_repository_urls}
Expand Down

0 comments on commit e847e49

Please sign in to comment.