Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention silent truncation of probing_rate>4 #803

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

t-nil
Copy link

@t-nil t-nil commented Jan 8, 2024

In target_quality.rs, fn adapt_probing_rate() is used to truncate the probing rate. This is not mentioned in the parameter description.

@FreezyLemon
Copy link
Contributor

This is surprising behaviour, and I did not know it worked like that. It might be even better to max it out at 4 and give a runtime warning..

@shssoichiro
Copy link
Collaborator

I second the above suggestion, I'd rather have less surprising behavior for the end user if possible. If it's possible to update this PR to make that change, it would be appreciated.

@t-nil
Copy link
Author

t-nil commented May 26, 2024

> ~/.cache/cargo_target/debug/av1an --probing-rate 5
error: invalid value '5' for '--probing-rate <PROBING_RATE>': 5 is not in 1..=4

For more information, try '--help'.

Should be mergable now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants