Implement alternate input for scene detection V2 #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreezyLemon
reviewed
Feb 27, 2024
| @@ -121,6 +121,10 @@ pub struct CliOpts { | |||
| #[clap(short, required = true)] | |||
| pub input: Vec<PathBuf>, | |||
|
|
|||
| /// Alternate input for scene detection (must have the same frame count) | |||
There was a problem hiding this comment.
What happens when the two inputs don't have the same frame count?
There was a problem hiding this comment.
What happens when the two inputs don't have the same frame count?
This needs a check, With at least a warning to prevent future hair pulling.
There was a problem hiding this comment.
This is indeed something that should be added to prevent... annoying reports in the future.
I still haven't tested what happens if the inputs don't have the same frame counts.
I'll do that over the weekend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #631
This is the refactored version of the patch.
I've build it and it seems to be fine.
Just need to do some test encodes.
Unit tests don't work properly, but that'll be fixed eventually.