Added code to hide publish button for user without tagmanager_use_custom_templates capability

[AltamashShaikh]

Description:

Added code to hide publish button for user without tagmanager_use_custom_templates capability
Fixes: #PG-3450, #784

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[snake14]

Looks good. I confirmed that the ability to publish new versions was hidden and displayed based on the user permissions as expected 👍

[snake14]

@araichyk If this PR looks alright to you, I can go ahead and merge it.

[araichyk]

Can't seem to reproduce the original issue for whatever reason. This change is hiding/unhiding the Publish button for me based on access level though.

Do we also want to remove the Publish link from this alert on TagEdit, TriggerEdit, and VariableEdit?

[AltamashShaikh]

Can't seem to reproduce the original issue for whatever reason. This change is hiding/unhiding the Publish button for me based on access level though.

Do we also want to remove the Publish link from this alert on TagEdit, TriggerEdit, and VariableEdit?

@araichyk Good point, will remove the link too 👍

[snake14]

Aside from the broken UI test cases, the changes look good to me 👍

[AltamashShaikh]

Aside from the broken UI test cases, the changes look good to me 👍

@snake14 UI tests fixed

[snake14]

Looks good. Confirmed that the publish link is no longer part of the success message after creating/updating items.

[araichyk]

The Publish and Versions links are now hidden for my user with the Write access level, but they're still there for Admin or higher access levels. Looks good 👍. Thanks for making those changes!