Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added code to flush localPaq if no callback set but trackPageView set, #PG-3463 #789

Closed
wants to merge 3 commits into from
Closed

Added code to flush localPaq if no callback set but trackPageView set, #PG-3463 #789

wants to merge 3 commits into from

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Added code to flush localPaq if no callback set but trackPageView set
Fixes: #PG-3463

Review

snake14
snake14 reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it should work for cases where no MTM pageview trigger applies to the current page. I just had one concern that I commented about.

Template/Tag/MatomoTag.web.js Outdated Show resolved Hide resolved
@snake14
Copy link
Contributor

snake14 commented May 14, 2024

Closing as we're rolling back the changes with #790

@snake14 snake14 closed this May 14, 2024
@snake14 snake14 deleted the PG-3463-flush-paq-when-no-callback branch May 14, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snake14 snake14 Awaiting requested review from snake14

Assignees
No one assigned
Labels
Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AltamashShaikh @snake14