PEP8 lib/matplotlib/patches.py #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| docstring.interpd.update( | ||
| AvailableArrowstyles = _pprint_styles(ArrowStyle._style_list), | ||
| AvailableConnectorstyles = _pprint_styles(ConnectionStyle._style_list), | ||
| AvailableArrowstyles=_pprint_styles(ArrowStyle._style_list), |
|
+1. Reading this PR took some stamina, so implementing it must have been even harder. What tools did you use to help you with this (or was it just hard graft)? |
|
I have flake8 running automatically in vim when I save a file. It helps me spot pep8 errors (I contribute to projects where patches need to be pep8 in order to be integrated) and runspyflake in addition; I have not yet worked on the pyflake warning, and I may have found a place or two which have bugs in them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new pull request on the pep8 compliance of patches.py, as asked by @pelson