Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log axvline #1247

Merged
merged 3 commits into from Sep 18, 2012
Merged

Log axvline #1247

merged 3 commits into from Sep 18, 2012

Conversation

pelson
Copy link
Member

@pelson pelson commented Sep 14, 2012

Fixes the exception in from #1246 of:

ValueError: It is not possible to compute transA - transB since transB 
cannot be inverted and there is no shortcut possible.

The fix was simple enough (added the has_inverse property to the Log transforms). The generated png for the tests looks perfect, unfortunately the PDF and SVGs are not. Strangely, when I run this from a script rather than from the tests, the PDF and SVGs are perfect, but the png produces a line in the wrong place. If anyone has any ideas what may be going on there, it would be greatly appreciated.

As it is, this is a bona fide bug fix, but there still exists some weirdness to investigate.

…F and SVG fail to produce suitable results.
@dmcdougall
Copy link
Member

@pelson Nice!

@dmcdougall
Copy link
Member

@pelson Which backend are you using for the png?

@pelson
Copy link
Member Author

pelson commented Sep 14, 2012

Now there is a good question. In the script, I have 'TkAgg'.

The pngs are bad when created from the Agg backend. Hmmm, curious. What is also funny is that the line produced in the test for SVG and PDF is different to that in the script. I'm sure I'm doing something daft.


ax.axvline(24.1)
ax.axhline(24.1)
plt.show()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs removing. Its not this that's causing the problem though.

@dmcdougall
Copy link
Member

Now there is a good question. In the script, I have 'TkAgg'.

The pngs are bad when created from the Agg backend.

How? The line is in a different place? Or is it bad quality?

Can you compare the line created with the agg backend and the line created with the cairo backend?

What is also funny is that the line produced in the test for SVG and PDF is different to that in the
script. I'm sure I'm doing something daft.

In some sense, that kind of makes sense. Doesn't the testing framework nuke all your rc defaults?

@pelson
Copy link
Member Author

pelson commented Sep 14, 2012

The line is in a different place?

Completely.

@dmcdougall
Copy link
Member

The line is in a different place?

Completely.

Bugger.

@pelson
Copy link
Member Author

pelson commented Sep 14, 2012

:-) indeed.

Ok. So I'm going to take stock, and have a good think about this one. The order of saving the results is important, so I think there is some caching issues going on. I'm happy to spend some time on this in the next couple of days to track this down.

…the affine/non-affine transformation of a BlendedGenericTransform.
@pelson
Copy link
Member Author

pelson commented Sep 17, 2012

This issue should now be completely resolved by this PR. The only remaining concern is getting the text in the image to pass on travis. I will add a new commit which removes the text from the images.

mdboom added a commit that referenced this pull request Sep 18, 2012
@mdboom mdboom merged commit 73e3131 into matplotlib:v1.2.x Sep 18, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants