Fix AttrituteError for .lower on tuple of strings #1427
Conversation
|
I'd like to get this in before the cut. @pelson You're awake. Does this solution look reasonable to you? |
| if is_string_like(ec): | ||
| ec = ec.lower() | ||
| elif is_sequence_of_strings(ec): | ||
| ec = [a.lower() for a in ec] |
There was a problem hiding this comment.
I'm not sure why this line exists? Initial testing suggests colour names are case insensitive. Does it fix anything?
There was a problem hiding this comment.
Ah, if colour names are case insensitive then it's unneeded. Thanks for pointing that out.
Morning! This looks like the correct approach, so I am confident we can get this into the RC today... we might just need a small tweak. |
|
@pelson Thanks. Your suggestion was an improvement. |
| if 'antialiaseds' not in kwargs and ec.lower() == "none": | ||
| kwargs['antialiaseds'] = False | ||
| if 'antialiaseds' not in kwargs and (is_string_like(ec) and | ||
| ec == "none"): |
There was a problem hiding this comment.
We've missed the .lower part here. Other than that, I'm more than happy to press the big green button 😄
|
@pelson Eyes like a hawk. Sorted now. Cheers. |
Fix AttrituteError for .lower on tuple of strings
|
Merged. Good stuff. Thanks @dmcdougall! |
Fixes #1424.