New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use an imagemap for the "fork me on github" ribbon #1474
Conversation
Right now, the ribbon on the front page blocks out the possiblity of clicking on the "Index" link, because the "Fork me on Github" link is on top of it. I've rectified this by providing an imagemap, which only makes part of the image clickable as a link. I've verified that it works under Firefox, Chromium, and w3m. I have also moved the ribbon from being only on the front page, to appearing on all pages, since that has the potential of inviting contributors more actively, as most people won't spend much time on the index page, once they are actually using matplotlib, whereas they will be peaking at the gallery, as well as the api docs, etc. I got the numbers for the ribbon from here: susestudio/studio-help#20, but then adjusted them so that the full upper left triangle would be clickable, and not just the ribbon.
Just to make it completely explicit, this change puts the github banner on all pages, not just the index page. 👍 |
I am in favour of the multi-page love. |
I'm cool with this being on every page. |
use an imagemap for the "fork me on github" ribbon
Pushed to website. |
While this change means that only the triangle works as a link to Github in the 1.2.0 documentation I'm still not able to click on the index link neither in Chrome or Firefox. Does it work for everybody else? |
@jenshnielsen mea culpa - I verified that the trangular mapped region was clickable, but somehow missed the fact that the links underneath are still not clickable. I just spent some time trying to route around this with |
another option would be to change 10px to 80px in this bit:
which moves that link out of the way of the "fork me" image - except I can't figure out where in sphinx this bit is generated (sidebar, presumably?) |
ok, I have a solution, PR coming shortly |
Right now, the ribbon on the front page blocks out the possiblity of clicking
on the "Index" link, because the "Fork me on Github" link is on top of it.
I've rectified this by providing an imagemap, which only makes part of the
image clickable as a link. I've verified that it works under Firefox, Chromium,
and w3m.
I have also moved the ribbon from being only on the front page, to
appearing on all pages, since that has the potential of inviting
contributors more actively, as most people won't spend much time on the
index page, once they are actually using matplotlib, whereas they will
be peaking at the gallery, as well as the api docs, etc.
I got the numbers for the ribbon from here: susestudio/studio-help#20, but then
adjusted them so that the full upper left triangle would be clickable, and not
just the ribbon.
this is a version of #1468 against v1.2.x