add get_segments method to collections.LineCollection #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When it takes only one, the abscissae default to np.arange(len(y))
… Also, because of the recurring problems with non-framework Pythons, importing the Mac OS X backend will now fail (instead of just issuing a warning) if Python is not installed as a framework.
The new test functions test_mollweide_forward_inverse_closure and test_mollweide_inverse_forward_closure test that the forward->inverse and inverse->forward compositions are approximate identities.
… test The goal was to exercise the MollweideAxes.MollweideTransform and MollweideAxes.InvertedMollweideTransform classes. The ax.transData property does not make use of either of these classes; the ax.transProjection property does.
Do not need to explicitly call set_zorder because it gets done in the call to coll.update.
Fix errorbar zorder v1.2
Document the C/C++ code guidelines
…euse the polygons can't work, so revert to the old method where each polygon is independent.
…using image resampling.
Make Axes.stem take at least one argument.
A disconnected callback cannot be reconnected
implemented inverse transform for Mollweide axes
hexbin log scale is broken in matplotlib 1.2.0
Mplot3d/crashfixes
… `download_url` so `setup.py register` works without additional intervention.
Conflicts: lib/matplotlib/axes.py
As mentioned in the review, get_verts does not strictly do what its name implies. Copy the comment from the set_verts declaration to explain why this is the case.
As mentioned in the review, the variables in get_segments should not have underscores. This removes them.
Fixed pylab for python3.
|
Looks good to me 👍 Thanks @toddrjen |
Linear tri interpolator
Using a stricter check to see if Python was installed as a framework.
Ignore kdevelop4 project files
As mentioned in the review, get_verts does not strictly do what its name implies. Copy the comment from the set_verts declaration to explain why this is the case.
As mentioned in the review, the variables in get_segments should not have underscores. This removes them.
…into get_segments
|
The extra functions break add_collection |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collections.LineCollection has a set_segments method that lets you set the vertices of the line segments in the collection. However, it has no corresponding get_segments method. This adds the method.
This version implements the suggestions from pelson on the last version of this pull request.