Make cbook safe to import while removing duplicate is_string_like; #1762
Conversation
| from the Python Cookbook -- hence the name cbook | ||
| from the Python Cookbook -- hence the name cbook. | ||
|
|
||
| This module is in transition, with the intention of migrating |
There was a problem hiding this comment.
This paragraph is the only potential bone of contention for me. Has there been general agreement on transitioning cbook? FWIW I've read #1647 and the relevant mailing list discussion and still haven't found a definitive strategy - personally, I think anything of that scale should be covered by a MEP with a full transition plan.
On the basis of my comments, I wonder if we are better off not pre-empting that work here, and simply removing this paragraph?
There was a problem hiding this comment.
Moving the methods to a newly named module is debattable, but I think deprecating unused methods should still be done. I'm a a bit swamped with work right now, but I'll submit a new PR soon.
|
Other than my comment, 👍 |
Simplify module docstring, removing mention of possible future changes.
Make cbook safe to import while removing duplicate is_string_like;
closes #1019, replaces #1662.