Make wx and wxagg work with wx 2.9.x on Mac. #1994
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This affects the wx* backends on OSX only. It removes Mac-specific code that was letting the Frame manage the toolbar directly, without using the Sizer. There was a comment saying that this was needed for OSX 10.3. With wx 2.9.x, however, this method of handling the toolbar does not work at all; no toolbar appears, and the program can hang or otherwise behave erratically. The Sizer method, however, works. The big question is whether the Sizer method works on the Mac with wx 2.8.x. If it does, then this can be merged.
|
@pelson, @dmcdougall, I think both of you have Macs. Do either of you have wx 2.8 installed? If so, would you please test this? I have only 2.9.4 cocoa. You should also be able to test the equivalent of this by running embedding_in_wx5.py, which is using the same method of placing the toolbar. There is still a glitch with 2.9.4 in the drawing of the zoom rectangle; it's ugly, but one can live with it. |
Closed
|
It looks like I pushed the wrong branch. I am closing this and have opened #2004. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects the wx* backends on OSX only. It removes Mac-specific
code that was letting the Frame manage the toolbar directly, without
using the Sizer. There was a comment saying that this was needed
for OSX 10.3. With wx 2.9.x, however, this method of handling
the toolbar does not work at all; no toolbar appears, and the
program can hang or otherwise behave erratically. The Sizer
method, however, works.
The big question is whether the Sizer method works on the Mac
with wx 2.8.x. If it does, then this can be merged.