Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved get_ticklabels kwarg #2628

Merged
merged 1 commit into from Jan 6, 2014
Merged

Conversation

tacaswell
Copy link
Member

Adds kwarg which to Axis.get_ticklabels, Axes.get_xticklabels, and Axes.get_yticklabels to match the pattern in other tick-related
functions

Closes #1715

@pelson
Copy link
Member

pelson commented Dec 9, 2013

This is a backwards incompatible change which could very easily impact anybody who subclasses Axes so an api_changes entry is certainly needed.

Other than that, looks fine to me.

@tacaswell
Copy link
Member Author

How is this reverse incompatible? All existing code should continue to work properly.

@tacaswell
Copy link
Member Author

Never mind, figured out where this can break things.

If a sub class overrides this function with the current api code which expects the new kwarg will cause exceptions to be raised.

@tacaswell
Copy link
Member Author

@pelson Entry added and re-based.

and Axes.get_yticklabels to match the pattern in other tick-related
functions

Closes matplotlib#1715
pelson added a commit that referenced this pull request Jan 6, 2014
@pelson pelson merged commit 124fbea into matplotlib:master Jan 6, 2014
@tacaswell tacaswell deleted the xticklabels_kwarg branch January 6, 2014 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

axes.get_xticklabels() doesn't return all tick labels.
2 participants