Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedded_webagg.py example needs patches #3204

Closed
mikofski opened this issue Jul 10, 2014 · 7 comments
Closed

embedded_webagg.py example needs patches #3204

mikofski opened this issue Jul 10, 2014 · 7 comments

Comments

@mikofski
Copy link

I reviewed issues related to webagg but couldn't find anything current. Probably this is already planned for the next stable release, but just in case I put the patches I needed to make the master branch 894f3df work in this Gist. I apologize for not sending a pull request, but I didn't want to fork the whole repo.

@tacaswell
Copy link
Member

Forking on github isn't really a big deal, but I turned this in to a PR.

Can you be a bit more descriptive about what the problem is and why this fixes it?

@mikofski
Copy link
Author

FigureCanvasWebAggCore.get_supported_filetypes_grouped() and FigureCanvasWebAggCore.get_default_filetype() are not a class methods, but FigureManagerWebAgg.get_javascript() calls them. These methods are in the superclass backend_bases.FigureCanvas

@mikofski
Copy link
Author

Note the 2nd diff embedded_webagg.py.patch is not needed. It is for this SO answer for example of user has matplotlib-1.3.1 not master branch 894f3df but instead downloads backend_webagg_core.py and web_backend/ into the same folder.

@tacaswell
Copy link
Member

Can you please do a proper or?

@tacaswell
Copy link
Member

PR, not or, sorry for the typo

@mikofski
Copy link
Author

and replace #3205? ok

@mikofski
Copy link
Author

I was wrong, this change has already been made in master, backend_bases.FigureCanvasBase.get_supported_filetypes_grouped() and backend_bases.FigureCanvasBase.get_default_filetype() have already been changed to class methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants