reverse changes to imports in embedding_webagg #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was wrong, this change has already been made in master, |
tacaswell
pushed a commit
that referenced
this pull request
Sep 12, 2015
tacaswell
pushed a commit
that referenced
this pull request
Mar 7, 2017
ENH: make texFontMap a property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As describted in matplotlib#3204 and matplotlib#3205, changes to
embedding_webagg.pywere not meant to be in this pull request.I tested this on Windows-7 (x64) and Ubuntu-14.14 in a virtualenv with
e9c7dcbinstalled by calling:Prior to the patch running
embedding_webagg.pyraised exceptions, becauseFigureManagerWebAgg.get_javascript()callsFigureCanvasWebAggCore.get_default_filetype()andFigureCanvasWebAggCore.get_supported_filetypes_grouped()as if they were class methods.