Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeType checking for unix #4062

Closed
beachdweller opened this issue Feb 2, 2015 · 10 comments
Closed

FreeType checking for unix #4062

beachdweller opened this issue Feb 2, 2015 · 10 comments

Comments

@beachdweller
Copy link

1.4.2 may have difficulty locating freetype2 on unix if pkg_config is not installed (correctly). To make the installation more robust, what about adding get_extension method to the FreeType class of setupext.py file?

@tacaswell
Copy link
Member

See #3976, #3713, and #3622

@tacaswell
Copy link
Member

@Autodrive Sorry, reading that message after I posted it comes across as way more hostile than I intended!

That message is mostly notes the other devs.

@beachdweller
Copy link
Author

From your first comment, I could learn about prior similar ones.

@tacaswell
Copy link
Member

@Autodrive Yes, but I should have been friendlier about it.

@pelson
Copy link
Member

pelson commented Feb 4, 2015

@tacaswell - you missed #3363, which also deals with Freetype (specifically getting the correct version string).

@Autodrive - I think it might be helpful if you could provide a PR which shows the kind of thing you had in mind (it doesn't have to be complete, just something to give focused feedback - it may be that by doing that we get some more information on the problem).

Cheers!

@jenshnielsen
Copy link
Member

On Mac there is an issue when pkg config is not installed. I tried fixing it in #3713 but it breaks other stuff.
We need to refactor and generalise the code a bit to make it possible to search more directories. It's been on my list of stuff that I want to fix for a long time. Just haven't gotten around to it.

@beachdweller
Copy link
Author

@pelson May I have your opinion based on which commit I should prepare a pull request? 1.4.2 (3a828dd)? Or any other?

@pelson
Copy link
Member

pelson commented Feb 6, 2015

May I have your opinion based on which commit I should prepare a pull request?

I can't give a definitive answer. If your change would be invasive, I'd target the master branch, otherwise if this is a bugfix with little impact other than making a specific case better, then the v1.4.x branch would be the target.

Stick it against master for now, and we can always back port.

Cheers,

@tacaswell
Copy link
Member

Definitely against master. @efiring made a compelling case that 1.4.3 should be the last maintenance release and we should just start working on 1.5 now.

@tacaswell tacaswell modified the milestones: v1.4.x, 1.5.0 Feb 7, 2015
@tacaswell tacaswell modified the milestones: next point release, proposed next point release Jul 16, 2015
@QuLogic
Copy link
Member

QuLogic commented May 15, 2017

Based on the linked issues, I think pkg-config is now required building Matplotlib, and the old fallback of freetype-config is just broken, so the only course of action is to install pkg-config.

@QuLogic QuLogic closed this as completed May 15, 2017
@QuLogic QuLogic modified the milestones: unassigned, 2.1 (next point release) May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants