Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master requires cycler 0.10.0 #6325

Closed
etgalloway opened this issue Apr 22, 2016 · 8 comments · Fixed by #6340
Closed

Master requires cycler 0.10.0 #6325

etgalloway opened this issue Apr 22, 2016 · 8 comments · Fixed by #6340
Assignees
Milestone

Comments

@etgalloway
Copy link

Master requires cycler 0.10.0, not 0.9.0+ (as specified in setupext.py).

For 0.9.0, importing matplotlib fails:

    In [1]: import matplotlib

        <<< SNIP >>>

        807     for prop in cycler_inst.keys:
        808         norm_prop = _prop_aliases.get(prop, prop)
    --> 809         cycler_inst.change_key(prop, norm_prop)
        810 
        811     return cycler_inst

    AttributeError: 'Cycler' object has no attribute 'change_key'

change_key was added to 0.10.0 according to the cycler release notes.

@WeatherGod
Copy link
Member

Huh, you are right. That got missed in my pull request. For some reason, I
thought it was added in 0.9...

On Fri, Apr 22, 2016 at 7:25 PM, etgalloway notifications@github.com
wrote:

Master requires cycler 0.10.0, not 0.9.0+ (as specified in setupext.py).

For 0.9.0, importing matplotlib fails:

In [1]: import matplotlib

    <<< SNIP >>>

    807     for prop in cycler_inst.keys:
    808         norm_prop = _prop_aliases.get(prop, prop)
--> 809         cycler_inst.change_key(prop, norm_prop)
    810
    811     return cycler_inst

AttributeError: 'Cycler' object has no attribute 'change_key'

change_key was added to 0.10.0 according to the cycler release notes.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#6325

@tacaswell tacaswell added this to the 2.0 (style change major release) milestone Apr 25, 2016
@zcarver
Copy link

zcarver commented Apr 27, 2016

I have got this error as well, is there a way to remedy this??

@etgalloway
Copy link
Author

@zcarver: try installing cycler 0.10.0.

@tacaswell
Copy link
Member

update cycler, we need to fix the dependency tracking.

tacaswell added a commit to tacaswell/matplotlib that referenced this issue Apr 27, 2016
@tacaswell tacaswell self-assigned this Apr 27, 2016
tacaswell added a commit to tacaswell/matplotlib that referenced this issue Apr 27, 2016
@akrherz
Copy link
Contributor

akrherz commented Jan 18, 2017

For whatever it is worth, I just built matplotlib 2.0.0 via python setup.py bdist_rpm and during the seemingly successful build it reported

REQUIRED DEPENDENCIES AND EXTENSIONS
    ...snipped...
                cycler: yes [using cycler version 0.9.0]

and of course later errored out as above when I attempted to use it.

@tacaswell
Copy link
Member

what is bdist_rpm and does it do anything to the dependency tracking?

attn @tomspur

@WeatherGod
Copy link
Member

WeatherGod commented Jan 18, 2017 via email

@tomspur
Copy link
Contributor

tomspur commented Jan 19, 2017

It seems the documentation of bdist_rpm on python 3 is not very helpful. The one with python 2 used to be more verbose.
We are not using it though because you have not much influence about the generated rpm and the resulting rpm is not complying with our rpm guidelines.

bdist_rpm is/was running the usual bdist and build commands then internally, so it should check for the dependencies as usual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants