Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add a generic "seaborn" style #6452

Closed
mwaskom opened this issue May 19, 2016 · 9 comments · Fixed by #6467
Closed

Please add a generic "seaborn" style #6452

mwaskom opened this issue May 19, 2016 · 9 comments · Fixed by #6467
Assignees
Milestone

Comments

@mwaskom
Copy link

mwaskom commented May 19, 2016

I'm glad that matplotlib has included seaborn aesthetics in its built-in style sheets. However, the way that the different elements of the seaborn aesthetics were split up (i.e., that there are separate seaborn-darkgrid, seaborn-deep`, etc.) is both a little confusing and produces results that are, imo, visually unappealing.

I would much prefer if there were also a single "seaborn" style that encompasses seaborn-darkgrid, seaborn-deep, and seaborn-notebook, so that doing plt.style.use("seaborn") would create plots that look the same as actually importing seaborn.

@tacaswell tacaswell added this to the 2.0 (style change major release) milestone May 19, 2016
@tacaswell
Copy link
Member

Did that PR to put styles in style sheets get merged?

@mwaskom
Copy link
Author

mwaskom commented May 19, 2016

Not sure, but I just came across this which prompted the issue.

@WeatherGod
Copy link
Member

Here is the PR that originally added the seaborn style sheets along with
discussion of rationale of splitting it up:
#4570

I have no problem with a unified seaborn style sheet, but right now, I
don't think we have the capability of recursively loading sheets as
specified in another sheet.

On Thu, May 19, 2016 at 12:13 PM, Thomas A Caswell <notifications@github.com

wrote:

Did that PR to put styles in style sheets get merged?


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#6452 (comment)

@mwaskom
Copy link
Author

mwaskom commented May 19, 2016

But you could just put all of the aesthetics into one sheet, right?

@WeatherGod
Copy link
Member

correct

On Thu, May 19, 2016 at 12:18 PM, Michael Waskom notifications@github.com
wrote:

But you could just put all of the aesthetics into one sheet, right?


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#6452 (comment)

@mwaskom
Copy link
Author

mwaskom commented May 19, 2016

Hah, I see now that I initially advocated for what I'm now objecting to... Although I think what I probably had in mind was that seaborn-darkgrid would correspond to the default seaborn aesthetics, i.e. darkgrid + notebook + deep palette.

Anyway, seeing the result of my hasty suggestion, I do think that it's not ideal because users who want their plots to look "like seaborn" should probably be able to do so with minimal effort. Currently you'd have to be aware of a number of relatively internal seaborn details (like the bad name for the default palette).

I also think that having so many "seaborn" styles is likely very confusing in the context of tools like this, because they totally dominate the list. Ultimately what to do about that is up to you folks, but I'd suggest that it might be better to scale back the extent to which matplotlib styles fully replicate the aesthetic control that seaborn has. (Similarly, the "ggplot" style is just one of the many themes that ggplot can do).

@WeatherGod
Copy link
Member

I would be completely in favor of putting in a consolidated "seaborn" style sheet. As for the other sheets, maybe a way to specify "sub-sheets" might help, perhaps? Is there any analogous concept in CSS?

@tacaswell
Copy link
Member

I am 👍 on adding a single 'seaborn' sheet, but am a bit worried about removing styles that we have been shipping for a year.

tacaswell added a commit to tacaswell/matplotlib that referenced this issue May 22, 2016
@tacaswell tacaswell self-assigned this May 22, 2016
tacaswell added a commit to tacaswell/matplotlib that referenced this issue May 23, 2016
@mwaskom
Copy link
Author

mwaskom commented May 24, 2016

Thanks @tacaswell !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants