Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make hist histype='step' return list of container instead list of list #827

Closed
wants to merge 2 commits into from

Conversation

piti118
Copy link
Contributor

@piti118 piti118 commented Apr 13, 2012

so that the last return value of hist can be used in legend consistently between 'bar' and 'step'
remake of PR #813

so that the last return value of hist can be used in legend consistently between 'bar' and 'step'
@mdboom
Copy link
Member

mdboom commented Jun 1, 2012

Sorry this has sat here for so long -- I'm going back through a number of PR's today.

This looks good. Since it changes the API in a backward incompatible way, can you add a CHANGELOG entry?

@pelson
Copy link
Member

pelson commented Jun 24, 2012

The real fix to this problem would be for plt.fill to return a Container instance. @mdboom & @leejjoon: Would that be backwards compatible & palatable?

@efiring
Copy link
Member

efiring commented Sep 2, 2012

@pelson, @mdboom, is there a reason this has not been merged yet?

@pelson
Copy link
Member

pelson commented Sep 2, 2012

I don't really have an issue with this PR as it is. However, my outstanding question (depending on the answer) might provide a better all-round solution (I assume you would then be able to "legend" the result of plt.fill too).

piti118 added a commit to piti118/matplotlib that referenced this pull request Oct 30, 2012
Conflicts:
	CHANGELOG
piti118 added a commit to piti118/matplotlib that referenced this pull request Oct 30, 2012
Conflicts:
	CHANGELOG
piti118 added a commit to piti118/matplotlib that referenced this pull request Nov 2, 2012
Conflicts:
	CHANGELOG
@piti118
Copy link
Contributor Author

piti118 commented Nov 5, 2012

I want to revive this PR.

I took a quick grep at the axes.py and it seems like the only place axes.fill gets used is in axes.hist.
I agree with what @pelson said, the better solution is to fix axes.fill.

I can close this PR and open another one with axes.fill fix. What do you think?

@pelson
Copy link
Member

pelson commented Nov 5, 2012

I had a quick look at this yesterday. I have a branch (not quite ready for the big time) here: https://github.com/pelson/matplotlib/tree/fill_as_a_collection

@piti118 : Feel free to take a look at that and work from that point if it is helpful.

Cheers,

@pelson
Copy link
Member

pelson commented Jan 9, 2014

PR is 2 years old so I'm closing it. Please feel free to update and re-invigorate this PR and it can be re-opened.

Thanks,

@pelson pelson closed this Jan 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants